From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4273FC32772 for ; Tue, 23 Aug 2022 16:57:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245394AbiHWQ51 (ORCPT ); Tue, 23 Aug 2022 12:57:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343821AbiHWQz4 (ORCPT ); Tue, 23 Aug 2022 12:55:56 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CE5EACA25 for ; Tue, 23 Aug 2022 07:17:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661264271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cNul7dRswnU49jAHhKW2/LuUqpnr2B4b53UC3aSpkn8=; b=S9FItnj8zntttGaTMoit7bdXO9pOXBmP27cGPnYLGrZ1rAT3nvPYfI7Zf7YN4mXrmshHxD bFmaB+APXJ1LCt3wZORVPvg141JVZdajOdQdkF42jZSDqFb/QyHd8YPYlp88RXuZWUTv6B TzckitMK9oN/iVnUIReEh63jhCMvqtc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-3-AyojJJ-mM6OE64Wv4v40zg-1; Tue, 23 Aug 2022 10:17:48 -0400 X-MC-Unique: AyojJJ-mM6OE64Wv4v40zg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 73327893155; Tue, 23 Aug 2022 14:17:27 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.72]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5185EC15BB3; Tue, 23 Aug 2022 14:17:26 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <166126004083.548536.11195647088995116235.stgit@warthog.procyon.org.uk> <166126006184.548536.12909933168251738646.stgit@warthog.procyon.org.uk> To: Matthew Wilcox Cc: dhowells@redhat.com, sfrench@samba.org, linux-cifs@vger.kernel.org, lsahlber@redhat.com, jlayton@kernel.org, dchinner@redhat.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, samba-technical@lists.samba.org Subject: Re: [PATCH 3/5] smb3: fix temporary data corruption in collapse range MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <719242.1661264245.1@warthog.procyon.org.uk> Date: Tue, 23 Aug 2022 15:17:25 +0100 Message-ID: <719244.1661264245@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org Matthew Wilcox wrote: > > filemap_write_and_wait(inode->i_mapping); > > + truncate_pagecache_range(inode, off, old_eof); > > It's a bit odd to writeback the entire file but then truncate only part > of it. XFS does the same part: Actually, filemap_write_and_wait() should check for error, yes. Is there something that combines these that we should use? invalidate_inode_pages2_range() for example. David