Re: [PATCH v2] smb: client: fix data loss due to broken rename(2)

[Paulo Alcantara <pc@manguebit.org>]

Ralph Boehme <slow@samba.org> writes:

> On 9/2/25 9:39 PM, Paulo Alcantara wrote:
>> Ralph Boehme <slow@samba.org> writes:
>> 
>>> Likely? How? Does a Windows client also do this stuff when the rename
>>> destination is open? All this additionaly complexity is only waiting for
>>> bugs to happen and now that we have POSIX Extensions back we should
>>> phase out this crap.
>> 
>> Claiming POSIX support and being unable to rename open files, that would
>> be even worse, no?
>
> with SMB3 POSIX support all this just works including renames, what are 
> you alluding to?

What I mean is renaming *open files*, which is currently broken in
cifs.ko for SMB2+.  IMHO, anyone using something that mentions POSIX
support would expect renaming open files just work like in any UNIX
enviroment.

The protocol allows us to implement such thing, so why not doing it?  If
you want to us to return -EBUSY when attempting to rename open files,
then we should mention it to the users to keep using SMB1 to have such
fundamental behavior working.