Linux CIFS filesystem development
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Tom Talpey <tom@talpey.com>
Cc: dhowells@redhat.com, Steve French <smfrench@gmail.com>,
	Steve French <sfrench@samba.org>,
	Stefan Metzmacher <metze@samba.org>,
	Paulo Alcantara <pc@manguebit.com>,
	Matthew Wilcox <willy@infradead.org>,
	CIFS <linux-cifs@vger.kernel.org>
Subject: Re: cifs RDMA restrictions
Date: Wed, 02 Apr 2025 20:26:57 +0100	[thread overview]
Message-ID: <843601.1743622017@warthog.procyon.org.uk> (raw)
In-Reply-To: <b8dbed47-8824-4b3a-b373-061e139ee7a4@talpey.com>

Hi Tom,

Btw, in smb_recv_buf(), am I reading it right that it doesn't actually pass
buf off to the RDMA layer, but rather just copies into it from a response
popped off of the reassembly queue?

If that's the case, it should be possible to collapse smbd_recv_buf() and
smbd_recv_page() into smbd_recv() and just replace the memcpy() with
copy_to_iter().

David


  reply	other threads:[~2025-04-02 19:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-01 16:55 cifs RDMA restrictions David Howells
2025-04-01 18:02 ` Tom Talpey
2025-04-01 19:34   ` David Howells
2025-04-02 17:02     ` Tom Talpey
2025-04-02 17:09       ` David Howells
     [not found]         ` <CAH2r5ms2J06tJr4VEVDgmcj_1uqOnhYzbC1ybrMWDm=f8wVDoA@mail.gmail.com>
2025-04-02 18:04           ` Tom Talpey
2025-04-02 19:26             ` David Howells [this message]
2025-04-02 19:36               ` Tom Talpey
2025-04-02 19:54                 ` [RFC PATCH] cifs: Collapse smbd_recv_*() into smbd_recv() and just use copy_to_iter() David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=843601.1743622017@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=metze@samba.org \
    --cc=pc@manguebit.com \
    --cc=sfrench@samba.org \
    --cc=smfrench@gmail.com \
    --cc=tom@talpey.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox