From: Paulo Alcantara <pc@manguebit.org>
To: nspmangalore@gmail.com, smfrench@gmail.com,
linux-cifs@vger.kernel.org, dhowells@redhat.com
Cc: Shyam Prasad N <sprasad@microsoft.com>, stable@vger.kernel.org
Subject: Re: [PATCH] cifs: all initializations for tcon should happen in tcon_info_alloc
Date: Mon, 30 Jun 2025 16:36:50 -0300 [thread overview]
Message-ID: <87104723045d2e07849384ba8e3b4cc0@manguebit.org> (raw)
In-Reply-To: <20250630174049.887492-1-sprasad@microsoft.com>
nspmangalore@gmail.com writes:
> From: Shyam Prasad N <sprasad@microsoft.com>
>
> Today, a few work structs inside tcon are initialized inside
> cifs_get_tcon and not in tcon_info_alloc. As a result, if a tcon
> is obtained from tcon_info_alloc, but not called as a part of
> cifs_get_tcon, we may trip over.
>
> Cc: <stable@vger.kernel.org>
stable? Makes no sense.
> Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>
> ---
> fs/smb/client/cifsproto.h | 1 +
> fs/smb/client/connect.c | 8 +-------
> fs/smb/client/misc.c | 6 ++++++
> 3 files changed, 8 insertions(+), 7 deletions(-)
Otherwise, looks good:
Reviewed-by: Paulo Alcantara (Red Hat) <pc@manguebit.org>
next prev parent reply other threads:[~2025-06-30 19:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 17:39 [PATCH] cifs: all initializations for tcon should happen in tcon_info_alloc nspmangalore
2025-06-30 18:15 ` Steve French
2025-06-30 19:36 ` Paulo Alcantara [this message]
2025-07-01 2:20 ` Shyam Prasad N
2025-07-01 2:47 ` Paulo Alcantara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87104723045d2e07849384ba8e3b4cc0@manguebit.org \
--to=pc@manguebit.org \
--cc=dhowells@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=smfrench@gmail.com \
--cc=sprasad@microsoft.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox