From: Paulo Alcantara <pc@cjr.nz>
To: ChenXiaoSong <chenxiaosong2@huawei.com>,
sfrench@samba.org, lsahlber@redhat.com
Cc: linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
linux-kernel@vger.kernel.org, chenxiaosong2@huawei.com,
yi.zhang@huawei.com, zhangxiaoxu5@huawei.com
Subject: Re: [PATCH v2] cifs: fix use-after-free on the link name
Date: Fri, 04 Nov 2022 14:56:57 -0300 [thread overview]
Message-ID: <871qqi1u3a.fsf@cjr.nz> (raw)
In-Reply-To: <20221104074441.634677-1-chenxiaosong2@huawei.com>
ChenXiaoSong <chenxiaosong2@huawei.com> writes:
> When opened a symlink, link name is from 'inode->i_link', but it may be
> reset to a new value when revalidate the dentry. If some processes get the
> link name on the race scenario, then UAF will happen on link name.
>
> Fix this by implementing 'get_link' interface to duplicate the link name.
>
> Fixes: 76894f3e2f71 ("cifs: improve symlink handling for smb2+")
> Signed-off-by: ChenXiaoSong <chenxiaosong2@huawei.com>
> ---
> fs/cifs/cifsfs.c | 26 +++++++++++++++++++++++++-
> fs/cifs/inode.c | 5 -----
> 2 files changed, 25 insertions(+), 6 deletions(-)
Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
next prev parent reply other threads:[~2022-11-04 17:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 7:44 [PATCH v2] cifs: fix use-after-free on the link name ChenXiaoSong
2022-11-04 17:56 ` Paulo Alcantara [this message]
[not found] ` <CAH2r5msDR41wQhtsAcE_pUvXXdvwWBBNdESvCkieBoy42vVhcA@mail.gmail.com>
2022-11-05 4:39 ` Fwd: " Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qqi1u3a.fsf@cjr.nz \
--to=pc@cjr.nz \
--cc=chenxiaosong2@huawei.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lsahlber@redhat.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=yi.zhang@huawei.com \
--cc=zhangxiaoxu5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox