From: Paulo Alcantara <pc@cjr.nz>
To: Tom Talpey <tom@talpey.com>,
smfrench@gmail.com, linux-cifs@vger.kernel.org
Cc: linkinjeon@kernel.org, senozhatsky@chromium.org,
bmt@zurich.ibm.com, longli@microsoft.com, dhowells@redhat.com,
Tom Talpey <tom@talpey.com>
Subject: Re: [PATCH v2 0/6] Reduce SMBDirect RDMA SGE counts and sizes
Date: Tue, 04 Oct 2022 15:42:01 -0300 [thread overview]
Message-ID: <871qrn5t3a.fsf@cjr.nz> (raw)
In-Reply-To: <cover.1663961449.git.tom@talpey.com>
Tom Talpey <tom@talpey.com> writes:
> Allocate fewer SGEs and standard packet sizes in both kernel SMBDirect
> implementations.
>
> The current maximum values (16 SGEs and 8192 bytes) cause failures on the
> SoftiWARP provider, and are suboptimal on others. Reduce these to 6 and
> 1364. Additionally, recode smbd_send() to work with as few as 2 SGEs,
> and for debug sanity, reformat client-side logging to more clearly show
> addresses, lengths and flags in the appropriate base.
>
> Tested over SoftiWARP and SoftRoCE with shell, Connectathon basic and general.
>
> v2: correct an uninitialized value issue found by Coverity
>
> Tom Talpey (6):
> Decrease the number of SMB3 smbdirect client SGEs
> Decrease the number of SMB3 smbdirect server SGEs
> Reduce client smbdirect max receive segment size
> Reduce server smbdirect max send/receive segment sizes
> Handle variable number of SGEs in client smbdirect send.
> Fix formatting of client smbdirect RDMA logging
>
> fs/cifs/smbdirect.c | 227 ++++++++++++++++----------------------
> fs/cifs/smbdirect.h | 14 ++-
> fs/ksmbd/transport_rdma.c | 6 +-
> 3 files changed, 109 insertions(+), 138 deletions(-)
Acked-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
prev parent reply other threads:[~2022-10-04 18:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 21:53 [PATCH v2 0/6] Reduce SMBDirect RDMA SGE counts and sizes Tom Talpey
2022-09-23 21:53 ` [PATCH v2 1/6] Decrease the number of SMB3 smbdirect client SGEs Tom Talpey
2022-09-23 21:53 ` [PATCH v2 2/6] Decrease the number of SMB3 smbdirect server SGEs Tom Talpey
2022-09-27 0:37 ` Namjae Jeon
2022-09-23 21:53 ` [PATCH v2 3/6] Reduce client smbdirect max receive segment size Tom Talpey
2022-09-23 21:53 ` [PATCH v2 4/6] Reduce server smbdirect max send/receive segment sizes Tom Talpey
2022-09-25 3:40 ` Namjae Jeon
2022-09-25 15:41 ` Tom Talpey
2022-09-26 1:13 ` Namjae Jeon
2022-09-26 17:24 ` Tom Talpey
2022-09-27 14:59 ` Bernard Metzler
2022-09-28 14:53 ` Tom Talpey
2022-09-29 7:17 ` Bernard Metzler
2022-09-27 0:36 ` Namjae Jeon
2022-09-23 21:53 ` [PATCH v2 5/6] Handle variable number of SGEs in client smbdirect send Tom Talpey
2022-09-23 21:54 ` [PATCH v2 6/6] Fix formatting of client smbdirect RDMA logging Tom Talpey
2022-09-25 3:45 ` [PATCH v2 0/6] Reduce SMBDirect RDMA SGE counts and sizes Namjae Jeon
2022-09-25 15:46 ` Tom Talpey
2022-09-29 5:02 ` Steve French
2022-09-29 15:15 ` Tom Talpey
2022-09-29 15:27 ` Steve French
2022-09-29 15:44 ` Tom Talpey
2022-10-04 18:42 ` Paulo Alcantara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qrn5t3a.fsf@cjr.nz \
--to=pc@cjr.nz \
--cc=bmt@zurich.ibm.com \
--cc=dhowells@redhat.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=senozhatsky@chromium.org \
--cc=smfrench@gmail.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox