From: Paulo Alcantara <pc@cjr.nz>
To: Ronnie Sahlberg <lsahlber@redhat.com>,
linux-cifs <linux-cifs@vger.kernel.org>
Cc: Steve French <smfrench@gmail.com>, Ronnie Sahlberg <lsahlber@redhat.com>
Subject: Re: [PATCH] cifs: destage dirty pages before re-reading them for cache=none
Date: Mon, 19 Sep 2022 11:46:09 -0300 [thread overview]
Message-ID: <871qs7l8we.fsf@cjr.nz> (raw)
In-Reply-To: <20220919053901.465232-2-lsahlber@redhat.com>
Ronnie Sahlberg <lsahlber@redhat.com> writes:
> This is the opposite case of kernel bugzilla 216301.
> If we mmap a file using cache=none and then proceed to update the mmapped
> area these updates are not reflected in a later pread() of that part of the
> file.
> To fix this we must first destage any dirty pages in the range before
> we allow the pread() to proceed.
>
> Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
> ---
> fs/cifs/file.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
next prev parent reply other threads:[~2022-09-19 14:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 5:39 Improved fix for reading stale data when cache=none Ronnie Sahlberg
2022-09-19 5:39 ` [PATCH] cifs: destage dirty pages before re-reading them for cache=none Ronnie Sahlberg
2022-09-19 14:46 ` Paulo Alcantara [this message]
2022-09-19 14:54 ` Enzo Matsumiya
2022-09-19 21:21 ` ronnie sahlberg
-- strict thread matches above, loose matches on Subject: below --
2022-09-19 21:37 Updated patch for the corruption with cache=none and mmap Ronnie Sahlberg
2022-09-19 21:37 ` [PATCH] cifs: destage dirty pages before re-reading them for cache=none Ronnie Sahlberg
2022-09-20 1:43 ` Tom Talpey
2022-09-20 4:08 ` Leif Sahlberg
2022-09-20 4:10 ` Steve French
2022-09-20 4:32 Ronnie Sahlberg
2022-09-20 4:44 ` Steve French
2022-09-20 19:08 ` Tom Talpey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qs7l8we.fsf@cjr.nz \
--to=pc@cjr.nz \
--cc=linux-cifs@vger.kernel.org \
--cc=lsahlber@redhat.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox