From: Paulo Alcantara <pc@cjr.nz>
To: Enzo Matsumiya <ematsumiya@suse.de>, linux-cifs@vger.kernel.org
Cc: smfrench@gmail.com, ronniesahlberg@gmail.com, nspmangalore@gmail.com
Subject: Re: [PATCH] cifs: fix some memory leak when negotiate/session setup fails
Date: Tue, 23 Aug 2022 14:45:48 -0300 [thread overview]
Message-ID: <8735dmj1kj.fsf@cjr.nz> (raw)
In-Reply-To: <20220823142531.9057-1-ematsumiya@suse.de>
Enzo Matsumiya <ematsumiya@suse.de> writes:
>
> Fix memory leaks from some ses fields when cifs_negotiate_protocol() or
> cifs_setup_session() fails in cifs_get_smb_ses().
>
> A leak from ses->domainName has also been identified in setup_ntlmv2_rsp()
> when session setup fails.
Those fields are already freed by sesInfoFree().
> These has been reported by kmemleak.
Could you please include the report in commit message?
next prev parent reply other threads:[~2022-08-23 19:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 14:25 [PATCH] cifs: fix some memory leak when negotiate/session setup fails Enzo Matsumiya
2022-08-23 17:45 ` Paulo Alcantara [this message]
2022-08-24 5:31 ` Steve French
2022-08-24 13:52 ` Enzo Matsumiya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735dmj1kj.fsf@cjr.nz \
--to=pc@cjr.nz \
--cc=ematsumiya@suse.de \
--cc=linux-cifs@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=ronniesahlberg@gmail.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox