public inbox for linux-cifs@vger.kernel.org
 help / color / mirror / Atom feed
From: Paulo Alcantara <pc@cjr.nz>
To: linux-cifs@vger.kernel.org, smfrench@gmail.com
Cc: ddiss@suse.de, aaptel@suse.com, stable@vger.kernel.org
Subject: Re: [PATCH] cifs: fix automount regression of dfs links
Date: Fri, 30 Apr 2021 17:56:35 -0300	[thread overview]
Message-ID: <8735v7qynw.fsf@cjr.nz> (raw)
In-Reply-To: <20210430180843.16920-1-pc@cjr.nz>

Paulo Alcantara <pc@cjr.nz> writes:

> Unfortunately we can't kfree() the UNC and prefix paths in
> cifs_smb3_do_mount() because they could have come from a chased DFS
> referral (automount) and we rely on the new values set in cifs_sb->ctx
> prior to calling cifs_mount().
>
> Instead, fix smb3_parse_devname() to not leak the UNC and prefix paths
> when parsing new share paths.
>
> Cc: <stable@vger.kernel.org> # v5.11+
> Fixes: 315db9a05b7a ("cifs: fix leak in cifs_smb3_do_mount() ctx")
> Signed-off-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
> ---
>  fs/cifs/cifsfs.c     |  6 ------
>  fs/cifs/connect.c    | 10 +++++++---
>  fs/cifs/fs_context.c |  2 ++
>  3 files changed, 9 insertions(+), 9 deletions(-)

Please ignore this patch.  The commit msg is also misleading.

I'll post another one soon.

      parent reply	other threads:[~2021-04-30 20:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-30 18:08 [PATCH] cifs: fix automount regression of dfs links Paulo Alcantara
2021-04-30 19:40 ` Steve French
2021-04-30 20:56 ` Paulo Alcantara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735v7qynw.fsf@cjr.nz \
    --to=pc@cjr.nz \
    --cc=aaptel@suse.com \
    --cc=ddiss@suse.de \
    --cc=linux-cifs@vger.kernel.org \
    --cc=smfrench@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox