From: Paulo Alcantara <pc@cjr.nz>
To: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>,
linux-cifs@vger.kernel.org, zhangxiaoxu5@huawei.com,
sfrench@samba.org, lsahlber@redhat.com, sprasad@microsoft.com,
rohiths@microsoft.com, smfrench@gmail.com
Subject: Re: [PATCH -next 0/3] cifs: Use some helper function for preamble size
Date: Tue, 23 Aug 2022 14:23:17 -0300 [thread overview]
Message-ID: <877d2yj2m2.fsf@cjr.nz> (raw)
In-Reply-To: <20220823125202.1156172-1-zhangxiaoxu5@huawei.com>
Zhang Xiaoxu <zhangxiaoxu5@huawei.com> writes:
>
> *** BLURB HERE ***
> The unfolded expression of header_preamble_size is too long, in addition,
> some expressions have specific semantics, e.g.:
> calculate the position of the mid,
> confirm it's smb2+ server or not.
>
> Zhang Xiaoxu (3):
> cifs: Use help macro to get the header preamble size
> cifs: Use help macro to get the mid header size
> cifs: Add helper function to check smb2+ server
>
> fs/cifs/cifsencrypt.c | 3 +--
> fs/cifs/cifsglob.h | 7 +++++++
> fs/cifs/connect.c | 28 +++++++++++-----------------
> fs/cifs/transport.c | 21 ++++++++++-----------
> 4 files changed, 29 insertions(+), 30 deletions(-)
Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
next prev parent reply other threads:[~2022-08-23 19:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 12:51 [PATCH -next 0/3] cifs: Use some helper function for preamble size Zhang Xiaoxu
2022-08-23 12:52 ` [PATCH -next 1/3] cifs: Use help macro to get the header " Zhang Xiaoxu
2022-08-23 12:52 ` [PATCH -next 2/3] cifs: Use help macro to get the mid header size Zhang Xiaoxu
2022-08-23 12:52 ` [PATCH -next 3/3] cifs: Add helper function to check smb1+ server Zhang Xiaoxu
2022-08-23 17:23 ` Paulo Alcantara [this message]
2022-08-24 5:57 ` [PATCH -next 0/3] cifs: Use some helper function for preamble size Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d2yj2m2.fsf@cjr.nz \
--to=pc@cjr.nz \
--cc=linux-cifs@vger.kernel.org \
--cc=lsahlber@redhat.com \
--cc=rohiths@microsoft.com \
--cc=sfrench@samba.org \
--cc=smfrench@gmail.com \
--cc=sprasad@microsoft.com \
--cc=zhangxiaoxu5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox