From: "Aurélien Aptel" <aaptel@suse.com>
To: Shyam Prasad N <nspmangalore@gmail.com>
Cc: CIFS <linux-cifs@vger.kernel.org>,
linux-fsdevel@vger.kernel.org, Steve French <smfrench@gmail.com>,
Paulo Alcantara <pc@cjr.nz>
Subject: Re: [PATCH v1] cifs: make nested cifs mount point dentries always valid to deal with signaled 'df'
Date: Mon, 01 Feb 2021 11:31:45 +0100 [thread overview]
Message-ID: <877dns9izy.fsf@suse.com> (raw)
In-Reply-To: <CANT5p=ofvpimU9Z7jwj4cPXXa1E4KkcijYrxbVKQZf5JDiR-1g@mail.gmail.com>
Shyam Prasad N <nspmangalore@gmail.com> writes:
> Going by the documentation of d_revalidate:
>> This function should return a positive value if the dentry is still
>> valid, and zero or a negative error code if it isn't.
>
> In case of error, can we try returning the rc itself (rather than 0),
> and see if VFS avoids a dentry put?
> Because theoretically, the call execution has failed, and the dentry
> is not found to be invalid.
AFAIK mount points are pinned, you cannot rm or mv them so it seems we
could make them always valid. I don't know if there are deeper and more
subtle implications.
The recent signal fixes are not fixing this issue.
Cheers,
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
next prev parent reply other threads:[~2021-02-01 10:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 17:13 [PATCH v1] cifs: make nested cifs mount point dentries always valid to deal with signaled 'df' Aurélien Aptel
2021-01-31 9:28 ` Shyam Prasad N
2021-02-01 10:31 ` Aurélien Aptel [this message]
2021-02-01 16:51 ` Shyam Prasad N
2021-02-02 11:00 ` Aurélien Aptel
2021-02-02 11:16 ` [PATCH v2] cifs: report error instead of invalid when revalidating a dentry fails Aurélien Aptel
2021-02-02 17:09 ` Shyam Prasad N
2021-02-02 17:34 ` Aurélien Aptel
2021-02-02 17:42 ` [PATCH v3] " Aurélien Aptel
2021-02-02 17:55 ` Steve French
2021-02-02 18:27 ` Shyam Prasad N
2021-02-02 18:26 ` Shyam Prasad N
2021-02-02 18:34 ` Aurélien Aptel
2021-02-03 4:24 ` Shyam Prasad N
2021-02-05 13:32 ` Shyam Prasad N
2021-02-05 14:42 ` [PATCH v4] " Aurélien Aptel
2021-02-05 14:52 ` Shyam Prasad N
2021-02-05 19:22 ` Steve French
2021-02-05 22:31 ` Steve French
2021-02-03 4:11 ` [PATCH v3] " Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dns9izy.fsf@suse.com \
--to=aaptel@suse.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=pc@cjr.nz \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox