From: Paulo Alcantara <pc@cjr.nz>
To: Steve French <smfrench@gmail.com>, CIFS <linux-cifs@vger.kernel.org>
Cc: Namjae Jeon <linkinjeon@kernel.org>
Subject: Re: [PATCH] fix ksmbd bigendian bug in oplock break, and move its struct and a few others to smbfs_common
Date: Tue, 29 Mar 2022 12:51:53 -0300 [thread overview]
Message-ID: <878rsszrhi.fsf@cjr.nz> (raw)
In-Reply-To: <CAH2r5mvDREEnghECdF3Okj6bwi1B6Dk=oM2tyxP=weYsZ7Am1g@mail.gmail.com>
Steve French <smfrench@gmail.com> writes:
> Fix an endian bug in ksmbd for one remaining use of
> Persistent/VolatileFid that unnecessarily converted it (it is an
> opaque endian field that does not need to be and should not
> be converted) in oplock_break for ksmbd, and move the definitions
> for the oplock and lease break protocol requests and responses
> to fs/smbfs_common/smb2pdu.h
>
> Also move a few more definitions for various protocol requests
> that were duplicated (in fs/cifs/smb2pdu.h and fs/ksmbd/smb2pdu.h)
> into fs/smbfs_common/smb2pdu.h including:
>
> - various ioctls and reparse structures
> - validate negotiate request and response structs
> - duplicate extents structs
Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
prev parent reply other threads:[~2022-03-29 15:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 23:04 [PATCH] fix ksmbd bigendian bug in oplock break, and move its struct and a few others to smbfs_common Steve French
2022-03-29 2:04 ` Namjae Jeon
2022-03-29 15:51 ` Paulo Alcantara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rsszrhi.fsf@cjr.nz \
--to=pc@cjr.nz \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox