From: "Aurélien Aptel" <aaptel@suse.com>
To: Shyam Prasad N <nspmangalore@gmail.com>,
Steve French <smfrench@gmail.com>,
CIFS <linux-cifs@vger.kernel.org>,
sribhat.msa@outlook.com, rohiths.msft@gmail.com
Subject: Re: [PATCH] cifs: Return the appropriate error in cifs_sb_tlink instead of a generic error.
Date: Tue, 29 Sep 2020 15:16:38 +0200 [thread overview]
Message-ID: <87blhok9jd.fsf@suse.com> (raw)
In-Reply-To: <CANT5p=ojR_Aac4bWSBqb3_FmzzjA6sHQBdN5z4o6c4nFDKmNDQ@mail.gmail.com>
Shyam Prasad N <nspmangalore@gmail.com> writes:
> One of the cases where this behaviour is confusing is where a
> new tcon needs to be constructed, but it fails due to
> expired keys. cifs_construct_tcon then returns ENOKEY,
> but we end up returning a EACCES to the user.
>
> Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>
LGTM
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
Cheers,
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
next prev parent reply other threads:[~2020-09-29 13:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 12:02 [PATCH] cifs: Return the appropriate error in cifs_sb_tlink instead of a generic error Shyam Prasad N
2020-09-29 13:16 ` Aurélien Aptel [this message]
2020-09-29 17:46 ` Steve French
2020-09-30 15:18 ` Shyam Prasad N
2020-09-30 15:57 ` Shyam Prasad N
2020-09-30 23:16 ` ronnie sahlberg
2020-10-01 5:12 ` Shyam Prasad N
[not found] ` <CAH2r5mtyE7+X6ayp8FfzWu5cyengtd=RMFD0XimZPFoJQ5h+PQ@mail.gmail.com>
2020-10-01 10:42 ` Shyam Prasad N
2020-10-01 11:29 ` ronnie sahlberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blhok9jd.fsf@suse.com \
--to=aaptel@suse.com \
--cc=linux-cifs@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=rohiths.msft@gmail.com \
--cc=smfrench@gmail.com \
--cc=sribhat.msa@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox