public inbox for linux-cifs@vger.kernel.org
 help / color / mirror / Atom feed
From: "Aurélien Aptel" <aaptel@suse.com>
To: Steve French <smfrench@gmail.com>, CIFS <linux-cifs@vger.kernel.org>
Subject: Re: oops running test 130
Date: Tue, 27 Apr 2021 13:46:30 +0200	[thread overview]
Message-ID: <87im48vtk9.fsf@suse.com> (raw)
In-Reply-To: <CAH2r5mvHQ63Sk=GUT5EdEHMT41SznR7dYQqFk_i+W4x2jxtwYw@mail.gmail.com>

Steve French <smfrench@gmail.com> writes:
> And note that rerunning the test with same config and same target
> server 10 minutes later ... I did not see the oops

>> [ 1967.512902] refcount_t: addition on 0; use-after-free.

from


>> [ 1967.513069]  open_cached_dir_by_dentry+0xc2/0xe0 [cifs]
>> [ 1967.513142]  cifs_dentry_needs_reval+0x6e/0x160 [cifs]
>> [ 1967.513173]  cifs_revalidate_dentry_attr+0x30/0x340 [cifs]
>> [ 1967.513201]  cifs_revalidate_dentry+0xf/0x20 [cifs]
>> [ 1967.513376]  cifs_d_revalidate+0x50/0x130 [cifs]
>> [ 1967.513408]  path_openat+0x794/0xff0
>> [ 1967.513412]  ? __bitmap_andnot+0x26/0x70
>> [ 1967.513415]  do_filp_open+0xa2/0x100
>> [ 1967.513419]  ? __check_heap_object+0x5c/0x140
>> [ 1967.513421]  ? __check_object_size+0xd4/0x1a0
>> [ 1967.513425]  ? alloc_fd+0xba/0x180
>> [ 1967.513429]  ? do_sys_openat2+0x248/0x310
>> [ 1967.513432]  do_sys_openat2+0x248/0x310

That sounds like a very likely regression from that commit:

commit ad7567bc65af
Author: Muhammad Usama Anjum <musamaanjum@gmail.com>
Date:   Thu Apr 15 20:24:09 2021 +0500

    cifs: remove unnecessary copies of tcon->crfid.fid


Cheers,
-- 
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)


      reply	other threads:[~2021-04-27 11:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26 22:35 oops running test 130 Steve French
2021-04-26 22:56 ` Steve French
2021-04-27 11:46   ` Aurélien Aptel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87im48vtk9.fsf@suse.com \
    --to=aaptel@suse.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox