Re: [PATCH] cifs: do not query ifaces on smb1 mounts

[Paulo Alcantara <pc@cjr.nz>]

Tom Talpey <tom@talpey.com> writes:

> On 1/9/2023 11:41 AM, Paulo Alcantara wrote:
>> Users have reported the following error on every 600 seconds
>> (SMB_INTERFACE_POLL_INTERVAL) when mounting SMB1 shares:
>> 
>> 	CIFS: VFS: \\srv\share error -5 on ioctl to get interface list
>> 
>> It's supported only by SMB2+, so do not query network interfaces on
>> SMB1 mounts.
>> 
>> Fixes: 6e1c1c08cdf3 ("cifs: periodically query network interfaces from server")
>> Signed-off-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
>> ---
>>   fs/cifs/cifsglob.h |  1 +
>>   fs/cifs/connect.c  | 18 ++++++++++++------
>>   2 files changed, 13 insertions(+), 6 deletions(-)
>> 
>> diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
>> index cfdd5bf701a1..931e9d5b21f4 100644
>> --- a/fs/cifs/cifsglob.h
>> +++ b/fs/cifs/cifsglob.h
>> @@ -1240,6 +1240,7 @@ struct cifs_tcon {
>>   #ifdef CONFIG_CIFS_DFS_UPCALL
>>   	struct list_head ulist; /* cache update list */
>>   #endif
>> +	bool			iface_query_poll:1;
>
> Why add such a special-case flag, instead of simply checking the
> dialect, or (betyter) the server's multichannel capability attribute?
>
> It seems fragile and untestable to set a flag like this, especially
> in the tcon, which has nothing to do with supporting the multichannel
> fsctl.

Makes sense.  I'll fix it in v2.

Thanks.