From: "Aurélien Aptel" <aaptel@suse.com>
To: Shyam Prasad N <nspmangalore@gmail.com>,
Steve French <smfrench@gmail.com>,
Pavel Shilovsky <piastryyy@gmail.com>,
tom@talpey.com, ronnie sahlberg <ronniesahlberg@gmail.com>,
CIFS <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH 2/4] cifs: Fix in error types returned for out-of-credit situations.
Date: Thu, 04 Feb 2021 11:16:15 +0100 [thread overview]
Message-ID: <87k0ronno0.fsf@suse.com> (raw)
In-Reply-To: <CANT5p=oaVbe2rz-38J=_XD7DqZN48Bap-myJW9v76=JLTvAetg@mail.gmail.com>
Shyam Prasad N <nspmangalore@gmail.com> writes:
> For cases of zero credits found even when there are no requests
> in flight, replaced ENOTSUPP with EDEADLK, since we're avoiding
> deadlock here by returning error.
Seems ok. libc can have different behaviours depending on error but it
should be ok I think and better than ENOTSUPP.
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
Cheers,
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
next prev parent reply other threads:[~2021-02-04 10:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 8:08 [PATCH 2/4] cifs: Fix in error types returned for out-of-credit situations Shyam Prasad N
2021-02-04 8:09 ` Shyam Prasad N
2021-02-04 10:16 ` Aurélien Aptel [this message]
2021-02-04 16:49 ` Steve French
2021-02-16 12:31 ` Shyam Prasad N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0ronno0.fsf@suse.com \
--to=aaptel@suse.com \
--cc=linux-cifs@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=piastryyy@gmail.com \
--cc=ronniesahlberg@gmail.com \
--cc=smfrench@gmail.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox