From: Paulo Alcantara <pc@cjr.nz>
To: Shyam Prasad N <nspmangalore@gmail.com>,
Steve French <smfrench@gmail.com>,
CIFS <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH] cifs: use a different reconnect helper for non-cifsd threads
Date: Tue, 15 Feb 2022 16:06:35 -0300 [thread overview]
Message-ID: <87leyckkzo.fsf@cjr.nz> (raw)
In-Reply-To: <CANT5p=oyS-49nAvmddV=s+VOz+TG0SG7RcTEs6f25g_2hC-rUQ@mail.gmail.com>
Hi Shyam,
Shyam Prasad N <nspmangalore@gmail.com> writes:
> My patch last week was not sufficient to fix some of the buildbot
> failures we saw recently.
> Please review and use the following patch for new buildbot runs.
>
> https://github.com/sprasad-microsoft/smb3-kernel-client/commit/2b599dec7c9399b66b56419fcb252ab37de94e3b.patch
Patch looks good, however you missed these:
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 053cb449eb16..2e00cd58a8b5 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -4416,7 +4416,7 @@ static int tree_connect_dfs_target(const unsigned int xid, struct cifs_tcon *tco
*/
if (rc && server->current_fullpath != server->origin_fullpath) {
server->current_fullpath = server->origin_fullpath;
- cifs_reconnect(tcon->ses->server, true);
+ cifs_signal_cifsd_for_reconnect(server, true);
}
dfs_cache_free_tgts(tl);
diff --git a/fs/cifs/netmisc.c b/fs/cifs/netmisc.c
index ebe236b9d9f5..235aa1b395eb 100644
--- a/fs/cifs/netmisc.c
+++ b/fs/cifs/netmisc.c
@@ -896,7 +896,7 @@ map_and_check_smb_error(struct mid_q_entry *mid, bool logErr)
if (class == ERRSRV && code == ERRbaduid) {
cifs_dbg(FYI, "Server returned 0x%x, reconnecting session...\n",
code);
- cifs_reconnect(mid->server, false);
+ cifs_signal_cifsd_for_reconnect(mid->server, false);
}
}
With that, feel free to add:
Acked-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
next prev parent reply other threads:[~2022-02-15 19:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 14:15 [PATCH] cifs: use a different reconnect helper for non-cifsd threads Shyam Prasad N
2022-02-15 19:06 ` Paulo Alcantara [this message]
2022-02-15 19:37 ` Steve French
2022-02-16 0:41 ` Steve French
[not found] ` <CANT5p=qHHCTT0EaQDiYediXNo5ATi1j_gZGhTW6+zyC5m6zY5g@mail.gmail.com>
2022-02-16 3:02 ` Steve French
2022-02-16 15:33 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87leyckkzo.fsf@cjr.nz \
--to=pc@cjr.nz \
--cc=linux-cifs@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox