From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8E18C55178 for ; Fri, 23 Oct 2020 09:19:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4DC2F2192A for ; Fri, 23 Oct 2020 09:19:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S461333AbgJWJTn convert rfc822-to-8bit (ORCPT ); Fri, 23 Oct 2020 05:19:43 -0400 Received: from mx2.suse.de ([195.135.220.15]:57322 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S461317AbgJWJTl (ORCPT ); Fri, 23 Oct 2020 05:19:41 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 96FE0ABF4 for ; Fri, 23 Oct 2020 09:19:40 +0000 (UTC) From: =?utf-8?Q?Aur=C3=A9lien?= Aptel To: Samuel Cabrero , linux-cifs@vger.kernel.org Cc: Samuel Cabrero Subject: Re: [PATCH 04/11] cifs: add witness mount option and data structs In-Reply-To: <20201022181339.30771-5-scabrero@suse.de> References: <20201022181339.30771-1-scabrero@suse.de> <20201022181339.30771-5-scabrero@suse.de> Date: Fri, 23 Oct 2020 11:19:40 +0200 Message-ID: <87lffxuwnn.fsf@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org Samuel Cabrero writes: > diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c > index 8111d0109a2e..c2bbc444b463 100644 > --- a/fs/cifs/cifsfs.c > +++ b/fs/cifs/cifsfs.c > @@ -637,6 +637,11 @@ cifs_show_options(struct seq_file *s, struct dentry *root) > seq_printf(s, ",multichannel,max_channels=%zu", > tcon->ses->chan_max); > > +#ifdef CONFIG_CIFS_SWN_UPCALL > + if (tcon->use_witness) > + seq_puts(s, ",witness"); > +#endif > + You should print it in cifs_debug_tcon() and print the KConfig option in cifs_debug_data_proc_show(). -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)