From: Paulo Alcantara <pc@cjr.nz>
To: Volker.Lendecke@sernet.de, linux-cifs@vger.kernel.org
Subject: Re: Fix posix 311 symlink creation mode
Date: Wed, 11 Jan 2023 10:57:33 -0300 [thread overview]
Message-ID: <87sfghkwc2.fsf@cjr.nz> (raw)
In-Reply-To: <Y76gvH9ADxSgAxSw@sernet.de>
Volker Lendecke <Volker.Lendecke@sernet.de> writes:
> Attached find a patch that fixes an uninitialized memory read when
> creating symlinks using the smb311 posix extensions.
>
> Volker
> From 482fa85ef97505626b6b146155834e6bc36012fa Mon Sep 17 00:00:00 2001
> From: Volker Lendecke <vl@samba.org>
> Date: Wed, 11 Jan 2023 12:37:58 +0100
> Subject: [PATCH] cifs: Fix uninitialized memory read for smb311 posix symlink
> create
>
> If smb311 posix is enabled, we send the intended mode for file
> creation in the posix create context. Instead of using what's there on
> the stack, create the mfsymlink file with 0644.
>
> Signed-off-by: Volker Lendecke <vl@samba.org>
> ---
> fs/cifs/link.c | 1 +
> 1 file changed, 1 insertion(+)
Looks good to me. Thanks!
Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
next prev parent reply other threads:[~2023-01-11 13:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 11:42 Fix posix 311 symlink creation mode Volker Lendecke
2023-01-11 13:57 ` Paulo Alcantara [this message]
2023-01-11 16:21 ` Steve French
2023-01-11 16:51 ` Volker Lendecke
2023-01-11 17:04 ` Tom Talpey
2023-01-11 20:18 ` Steve French
2023-01-12 13:25 ` David Disseldorp
2023-01-12 15:59 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfghkwc2.fsf@cjr.nz \
--to=pc@cjr.nz \
--cc=Volker.Lendecke@sernet.de \
--cc=linux-cifs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox