From: Paulo Alcantara <pc@cjr.nz>
To: "Aurélien Aptel" <aurelien.aptel@gmail.com>
Cc: smfrench@gmail.com, linux-cifs@vger.kernel.org
Subject: Re: [PATCH 1/5] cifs: fix potential deadlock in cache_refresh_path()
Date: Tue, 17 Jan 2023 15:03:18 -0300 [thread overview]
Message-ID: <87v8l5ujh5.fsf@cjr.nz> (raw)
In-Reply-To: <CA+5B0FPp5ELawadvymYumQPSaCrCL15=2_KiCX2=91u6KBoVyw@mail.gmail.com>
Aurélien Aptel <aurelien.aptel@gmail.com> writes:
> On Tue, Jan 17, 2023 at 1:35 AM Paulo Alcantara <pc@cjr.nz> wrote:
>> - down_write(&htable_rw_lock);
>> + down_read(&htable_rw_lock);
>>
>> ce = lookup_cache_entry(path);
>> - if (!IS_ERR(ce)) {
>> - if (!cache_entry_expired(ce)) {
>> - dump_ce(ce);
>> - up_write(&htable_rw_lock);
>> - return 0;
>> - }
>> - } else {
>> - newent = true;
>> + if (!IS_ERR(ce) && !cache_entry_expired(ce)) {
>> + up_read(&htable_rw_lock);
>> + return 0;
>> }
>>
>> + up_read(&htable_rw_lock);
>
> Please add a comment before the up_read() to say why you do it here
> and where is the dead lock.
Ok, thanks. Will send v2 with your suggestions.
next prev parent reply other threads:[~2023-01-17 18:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 0:09 [PATCH 0/5] dfs fixes Paulo Alcantara
2023-01-17 0:09 ` [PATCH 1/5] cifs: fix potential deadlock in cache_refresh_path() Paulo Alcantara
2023-01-17 17:07 ` Aurélien Aptel
2023-01-17 18:03 ` Paulo Alcantara [this message]
2023-01-17 0:09 ` [PATCH 2/5] cifs: avoid re-lookups in dfs_cache_find() Paulo Alcantara
2023-01-17 0:09 ` [PATCH 3/5] cifs: don't take exclusive lock for updating target hints Paulo Alcantara
2023-01-17 0:09 ` [PATCH 4/5] cifs: remove duplicate code in __refresh_tcon() Paulo Alcantara
2023-01-17 0:09 ` [PATCH 5/5] cifs: handle cache lookup errors different than -ENOENT Paulo Alcantara
2023-01-17 22:00 ` [PATCH v2 0/5] dfs fixes Paulo Alcantara
2023-01-17 22:00 ` [PATCH v2 1/5] cifs: fix potential deadlock in cache_refresh_path() Paulo Alcantara
2023-01-17 22:00 ` [PATCH v2 2/5] cifs: avoid re-lookups in dfs_cache_find() Paulo Alcantara
2023-01-17 22:00 ` [PATCH v2 3/5] cifs: don't take exclusive lock for updating target hints Paulo Alcantara
2023-01-17 22:00 ` [PATCH v2 4/5] cifs: remove duplicate code in __refresh_tcon() Paulo Alcantara
2023-01-17 22:00 ` [PATCH v2 5/5] cifs: handle cache lookup errors different than -ENOENT Paulo Alcantara
2023-01-18 1:33 ` [PATCH v2 0/5] dfs fixes Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8l5ujh5.fsf@cjr.nz \
--to=pc@cjr.nz \
--cc=aurelien.aptel@gmail.com \
--cc=linux-cifs@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox