From: Paulo Alcantara <pc@manguebit.com>
To: tbecker@redhat.com, linux-cifs@vger.kernel.org
Cc: Thiago Becker <tbecker@redhat.com>
Subject: Re: [PATCH 2/2] cifscreds: allow user to set the key's timeout
Date: Mon, 20 Jan 2025 13:07:40 -0300 [thread overview]
Message-ID: <90e00aca77426f60e0a3d563c8644d6e@manguebit.com> (raw)
In-Reply-To: <20250114203509.172766-1-tbecker@redhat.com>
tbecker@redhat.com writes:
> From: Thiago Becker <tbecker@redhat.com>
>
> Allow the user to set the key's timeout when adding a new credential.
>
> Signed-off-by: Thiago Becker <tbecker@redhat.com>
> ---
> cifscreds.c | 17 +++++++++++------
> cifskey.c | 12 ++++++++++--
> cifskey.h | 7 ++++++-
> pam_cifscreds.c | 4 ++--
> 4 files changed, 29 insertions(+), 11 deletions(-)
LGTM. Do you mind to send a patch to update cifscreds.rst with the new
parameter so the user will know it should be in seconds?
Reviewed-by: Paulo Alcantara (Red Hat) <pc@manguebit.com>
Thanks.
next prev parent reply other threads:[~2025-01-20 16:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 20:35 [PATCH 2/2] cifscreds: allow user to set the key's timeout tbecker
2025-01-20 16:07 ` Paulo Alcantara [this message]
2025-01-24 17:52 ` [PATCH vvv] " tbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90e00aca77426f60e0a3d563c8644d6e@manguebit.com \
--to=pc@manguebit.com \
--cc=linux-cifs@vger.kernel.org \
--cc=tbecker@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox