Re: [PATCH v2 1/1] smb/server: fix refcount leak in smb2_open()

[ChenXiaoSong <chenxiaosong@chenxiaosong.com>]

Hi Namjae,

By the way, smb2_open() is over 900 lines long, and we have already 
encountered several memory leaks in it, and there may be more. Perhaps 
we should consider refactoring it to make it easier to maintain.

What do you think?

Thanks,
ChenXiaoSong <chenxiaosong@chenxiaosong.com>

On 2026/2/27 12:07, ChenXiaoSong wrote:
> Hi Guenter,
> 
> Sorry for the late reply. I had some family matters to take care of 
> yesterday.
> 
> Please see the following process:
> 
> ```
> smb2_open
>    smb2_check_durable_oplock
>      opinfo_get(fp) // inc refcount
>    ksmbd_reopen_durable_fd
>      __open_id(&work->sess->file_table, fp,
>        idr_alloc_cyclic(ft->idr, fp, ...)
>        __open_id_set(fp, id, type); // insert into file table
>    ksmbd_override_fsids // fail
>    ksmbd_put_durable_fd
>      __ksmbd_close_fd
>        __ksmbd_remove_fd  // remove dh_info.fp from file table
>    // dh_info.fp has already been removed from the file table
>    ksmbd_fd_put(..., fp) // fp == NULL
> ```