From: Paulo Alcantara <pc@manguebit.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Pavel Shilovsky <pshilovsky@samba.org>
Cc: linux-cifs@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH cifs-utils] cldap_ping.c: add missing <sys/types.h> include
Date: Mon, 20 Jan 2025 13:10:28 -0300 [thread overview]
Message-ID: <92333abc251f433ebe5e0cca280f7426@manguebit.com> (raw)
In-Reply-To: <20241226204235.2311371-1-thomas.petazzoni@bootlin.com>
Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> Fixes:
>
> cldap_ping.c: In function ‘read_dns_string’:
> cldap_ping.c:72:37: error: ‘u_char’ undeclared (first use in this function)
>
> when building with the musl C library, but even with glibc u_char is
> defined in <sys/types.h>, it happens to work with glibc <sys/types.h>
> gets included by another header.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> cldap_ping.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Paulo Alcantara (Red Hat) <pc@manguebit.com>
prev parent reply other threads:[~2025-01-20 16:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-26 20:42 [PATCH cifs-utils] cldap_ping.c: add missing <sys/types.h> include Thomas Petazzoni
2025-01-20 16:10 ` Paulo Alcantara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92333abc251f433ebe5e0cca280f7426@manguebit.com \
--to=pc@manguebit.com \
--cc=linux-cifs@vger.kernel.org \
--cc=pshilovsky@samba.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox