Linux CIFS filesystem development
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: chenxiaosong.chenxiaosong@linux.dev
Cc: dhowells@redhat.com, sfrench@samba.org, smfrench@gmail.com,
	linkinjeon@kernel.org, linkinjeon@samba.org, pc@manguebit.org,
	ronniesahlberg@gmail.com, sprasad@microsoft.com, tom@talpey.com,
	bharathsm@microsoft.com, senozhatsky@chromium.org,
	linux-cifs@vger.kernel.org,
	ChenXiaoSong <chenxiaosong@kylinos.cn>
Subject: Re: [PATCH v4 2/2] smb/server: fix minimum SMB2 PDU size
Date: Sat, 20 Dec 2025 15:19:33 +0000	[thread overview]
Message-ID: <941517.1766243973@warthog.procyon.org.uk> (raw)
In-Reply-To: <20251220132551.351932-3-chenxiaosong.chenxiaosong@linux.dev>

chenxiaosong.chenxiaosong@linux.dev wrote:

> The minimum SMB2 PDU size should be updated to the size of
> `struct smb2_pdu` (that is, the size of `struct smb2_hdr` + 2).

smb_hdr + 4.

but, apart from that:

	Reviewed-by: David Howells <dhowells@redhat.com>

to both.

Do you actually need two patches for this?  Though granted, only the first one
is an actual fix.

David


  reply	other threads:[~2025-12-20 15:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-20 13:25 [PATCH v4 0/2] smb/server: fix minimum PDU size chenxiaosong.chenxiaosong
2025-12-20 13:25 ` [PATCH v4 1/2] smb/server: fix minimum SMB1 " chenxiaosong.chenxiaosong
2025-12-20 13:25 ` [PATCH v4 2/2] smb/server: fix minimum SMB2 " chenxiaosong.chenxiaosong
2025-12-20 15:19   ` David Howells [this message]
2025-12-20 15:50     ` ChenXiaoSong
2025-12-20 15:59     ` ChenXiaoSong
2025-12-21 22:51 ` [PATCH v4 0/2] smb/server: fix minimum " Namjae Jeon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=941517.1766243973@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=bharathsm@microsoft.com \
    --cc=chenxiaosong.chenxiaosong@linux.dev \
    --cc=chenxiaosong@kylinos.cn \
    --cc=linkinjeon@kernel.org \
    --cc=linkinjeon@samba.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=pc@manguebit.org \
    --cc=ronniesahlberg@gmail.com \
    --cc=senozhatsky@chromium.org \
    --cc=sfrench@samba.org \
    --cc=smfrench@gmail.com \
    --cc=sprasad@microsoft.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox