Re: [PATCH v8 2/5] cifs: Autogenerate SMB2 error mapping table

[ChenXiaoSong <chenxiaosong.chenxiaosong@linux.dev>]

In this patch, I added the following comments to make the code easier to 
understand. Please see GitHub repository tag `smb2maperror`: 
https://github.com/chenxiaosonggithub/linux/commits/smb2maperror/

--- a/fs/smb/common/smb2status.h
+++ b/fs/smb/common/smb2status.h
@@ -27,6 +27,12 @@ struct ntstatus {
         __le32 Code;
  };

+/*
+ * The comment at the end of each definition indicates `posix_error`
+ * field of `struct status_to_posix_error`, it is used to generate the
+ * `smb2_error_map_table` array.
+ */
+
  #define STATUS_SUCCESS                         cpu_to_le32(0x00000000) 
// 0
  #define STATUS_WAIT_0                          cpu_to_le32(0x00000000) 
// 0
  #define STATUS_WAIT_1                          cpu_to_le32(0x00000001) 
// -EIO

Thanks,
ChenXiaoSong <chenxiaosong@kylinos.cn>

On 1/6/26 15:15, chenxiaosong.chenxiaosong@linux.dev wrote:
> From: David Howells<dhowells@redhat.com>
> 
> Autogenerate the SMB2 status to error code mapping table, from the
> smb2status.h common header, sorting it by NT status code so that it can be
> searched by binary chopping. This also reduces the number of places this
> list is duplicated in the source.