From: Tom Talpey <tom@talpey.com>
To: Namjae Jeon <linkinjeon@kernel.org>, linux-cifs@vger.kernel.org
Subject: Re: [PATCH 1/3] ksmbd: reduce smb direct max read/write size
Date: Sun, 30 Jan 2022 14:04:23 -0500 [thread overview]
Message-ID: <9bd2b636-ca5a-df2c-49ab-db14b7b453f1@talpey.com> (raw)
In-Reply-To: <20220130093433.8319-1-linkinjeon@kernel.org>
On 1/30/2022 4:34 AM, Namjae Jeon wrote:
> To support RDMA in chelsio NICs, Reduce smb direct read/write size
> to about 512KB. With this change, we have checked that a single buffer
> descriptor was sent from Windows client, and intel X722 was operated at
> that size.
I am guessing that the larger payload required a fast-register of a page
count which was larger than the adapter supports? Can you provide more
detail?
Also, what exactly does "single buffer descriptor from Windows client"
mean, and why is it relevant?
Confused,
Tom.
> Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
> ---
> fs/ksmbd/transport_rdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ksmbd/transport_rdma.c b/fs/ksmbd/transport_rdma.c
> index 3c1ec1ac0b27..ba5a22bc2e6d 100644
> --- a/fs/ksmbd/transport_rdma.c
> +++ b/fs/ksmbd/transport_rdma.c
> @@ -80,7 +80,7 @@ static int smb_direct_max_fragmented_recv_size = 1024 * 1024;
> /* The maximum single-message size which can be received */
> static int smb_direct_max_receive_size = 8192;
>
> -static int smb_direct_max_read_write_size = 1048512;
> +static int smb_direct_max_read_write_size = 524224;
>
> static int smb_direct_max_outstanding_rw_ops = 8;
>
next prev parent reply other threads:[~2022-01-30 19:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-30 9:34 [PATCH 1/3] ksmbd: reduce smb direct max read/write size Namjae Jeon
2022-01-30 9:34 ` [PATCH 2/3] ksmbd: fix same UniqueId for dot and dotdot entries Namjae Jeon
2022-01-30 9:34 ` [PATCH 3/3] ksmbd: don't align last entry offset in smb2 query directory Namjae Jeon
2022-01-30 19:04 ` Tom Talpey [this message]
2022-01-31 1:07 ` [PATCH 1/3] ksmbd: reduce smb direct max read/write size Namjae Jeon
2022-01-31 3:18 ` Tom Talpey
2022-01-31 5:09 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bd2b636-ca5a-df2c-49ab-db14b7b453f1@talpey.com \
--to=tom@talpey.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox