Re: [PATCH] cifs: implementation id context as negotiate context

Henrique Carvalho
2026-03-06T22:45:26Z

On Wed, Mar 04, 2026 at 06:04:05PM +0530, Shyam Prasad N wrote: > On Wed, Mar 4, 2026 at 5:59 PM <nspmangalore@gmail.com> wrote: From: Shyam Prasad N <sprasad@microsoft.com>
>
> A proof-of-concept based on this draft from Bharath.
> Looking for comments on how to improve.

Looks good.

Just one minor thing for now. To me the cifs.ko module version doesn't
say much as it seems to be not reliable (apologies if I'm mistaken).

Also, the same version could have different implementations in different
distributions. modinfo -F srcversion cifs is a better way to
differentiate cifs versions but not to compare versions. So the solution
is either remove this or bump it in every change using X.Y.Z.

Further, have you thought about how the client can use this in its favor
other than diagnosing/debugging a faulty server?

I think we need to be clear on what is allowed here, to me it seems
quirks, workarounds and perf tuning? Maybe this can be used to improve
interaction between linux client and linux server?

Thanks,

--
Henrique
SUSE Labs