* [PATCH] ksmbd: Fix parameter name and comment mismatch
@ 2023-02-06 7:20 Jiapeng Chong
2023-02-06 14:41 ` Namjae Jeon
2023-02-07 1:52 ` Sergey Senozhatsky
0 siblings, 2 replies; 3+ messages in thread
From: Jiapeng Chong @ 2023-02-06 7:20 UTC (permalink / raw)
To: linkinjeon
Cc: sfrench, senozhatsky, tom, linux-cifs, linux-kernel,
Jiapeng Chong, Abaci Robot
fs/ksmbd/vfs.c:965: warning: Function parameter or member 'attr_value' not described in 'ksmbd_vfs_setxattr'.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3946
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
fs/ksmbd/vfs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/ksmbd/vfs.c b/fs/ksmbd/vfs.c
index aa1300b7bfc2..5ea9229dad2c 100644
--- a/fs/ksmbd/vfs.c
+++ b/fs/ksmbd/vfs.c
@@ -952,9 +952,9 @@ ssize_t ksmbd_vfs_getxattr(struct mnt_idmap *idmap,
* ksmbd_vfs_setxattr() - vfs helper for smb set extended attributes value
* @idmap: idmap of the relevant mount
* @dentry: dentry to set XATTR at
- * @name: xattr name for setxattr
- * @value: xattr value to set
- * @size: size of xattr value
+ * @attr_name: xattr name for setxattr
+ * @attr_value: xattr value to set
+ * @attr_size: size of xattr value
* @flags: destination buffer length
*
* Return: 0 on success, otherwise error
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ksmbd: Fix parameter name and comment mismatch
2023-02-06 7:20 [PATCH] ksmbd: Fix parameter name and comment mismatch Jiapeng Chong
@ 2023-02-06 14:41 ` Namjae Jeon
2023-02-07 1:52 ` Sergey Senozhatsky
1 sibling, 0 replies; 3+ messages in thread
From: Namjae Jeon @ 2023-02-06 14:41 UTC (permalink / raw)
To: Jiapeng Chong
Cc: sfrench, senozhatsky, tom, linux-cifs, linux-kernel, Abaci Robot
2023-02-06 16:20 GMT+09:00, Jiapeng Chong <jiapeng.chong@linux.alibaba.com>:
> fs/ksmbd/vfs.c:965: warning: Function parameter or member 'attr_value' not
> described in 'ksmbd_vfs_setxattr'.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3946
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ksmbd: Fix parameter name and comment mismatch
2023-02-06 7:20 [PATCH] ksmbd: Fix parameter name and comment mismatch Jiapeng Chong
2023-02-06 14:41 ` Namjae Jeon
@ 2023-02-07 1:52 ` Sergey Senozhatsky
1 sibling, 0 replies; 3+ messages in thread
From: Sergey Senozhatsky @ 2023-02-07 1:52 UTC (permalink / raw)
To: Jiapeng Chong
Cc: linkinjeon, sfrench, senozhatsky, tom, linux-cifs, linux-kernel,
Abaci Robot
On (23/02/06 15:20), Jiapeng Chong wrote:
>
> fs/ksmbd/vfs.c:965: warning: Function parameter or member 'attr_value' not described in 'ksmbd_vfs_setxattr'.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3946
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-07 1:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-06 7:20 [PATCH] ksmbd: Fix parameter name and comment mismatch Jiapeng Chong
2023-02-06 14:41 ` Namjae Jeon
2023-02-07 1:52 ` Sergey Senozhatsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox