Re: [PATCH v2 12/12] use less confusing names for iov_iter direction initializers

Al Viro
2022-10-30T05:01:59Z

On Fri, Oct 28, 2022 at 01:34:05PM -0700, Linus Torvalds wrote:
> On Fri, Oct 28, 2022 at 12:30 PM Al Viro <viro@zeniv.linux.org.uk> wrote:
> >
> > Went through the callers, replaced each with the right ITER_... (there's
> > not that many of them and they are fairly easy to review), then went
> > through mismatches and split their fixups into the beginning of the
> > series (READ -> ITER_SOURCE becoming READ -> WRITE -> ITER_SOURCE, that
> > is).
>
> Oh, ok. So if you've actually reviewed each and every one of them,
> then I'm ok with the "abort".
>
> I still want it to be a WARN_ON_ONCE(), because of any future addition
> that gets things wrong.

Sure, np; branch updated and pushed out - the only difference is that
11/12 adds WARN_ON_ONCE instead of WARN_ON, so no point reposting, IMO...