From: Christoph Hellwig <hch@infradead.org>
To: David Disseldorp <ddiss@samba.org>
Cc: Jeremy Allison via samba-technical
<samba-technical@lists.samba.org>,
CIFS <linux-cifs@vger.kernel.org>,
Amir Goldstein <amir73il@gmail.com>,
metze@samba.org, Steve French <smfrench@gmail.com>,
vl@samba.org, Jeremy Allison <jra@samba.org>
Subject: Re: reflink support and Samba running over XFS
Date: Thu, 10 Nov 2022 03:42:28 -0800 [thread overview]
Message-ID: <Y2zjpE6f6WLtkqiz@infradead.org> (raw)
In-Reply-To: <20221109233055.43b26632@echidna.suse.de>
On Wed, Nov 09, 2022 at 11:30:55PM +0100, David Disseldorp via samba-technical wrote:
> I think it's doable too :-). As indicated in my other mail, I think
> FICLONERANGE will need to be used for FSCTL_DUP_EXTENTS_TO_FILE instead
> of copy_file_range().
> I'm not sure how to best handle FILE_SUPPORTS_BLOCK_REFCOUNTING -
> ideally we'd set it for Btrfs and XFS(reflink=1) backed shares only.
> Another option might be to advertise FILE_SUPPORTS_BLOCK_REFCOUNTING and
> then propagate errors up to the client if FICLONERANGE fails for
> FSCTL_DUP_EXTENTS_TO_FILE. Client copy fallback would work, but the
> extra request overhead would be ugly.
We could probably add a bit to struct statx if that is helpful for
samba.
next prev parent reply other threads:[~2022-11-10 11:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 0:45 reflink support and Samba running over XFS Steve French
2022-11-08 0:53 ` Jeremy Allison
2022-11-08 6:47 ` Christoph Hellwig
2022-11-08 17:51 ` Jeremy Allison
2022-11-09 7:43 ` Christoph Hellwig
2022-11-09 9:32 ` Amir Goldstein
2022-11-09 18:38 ` Jeremy Allison
2022-11-09 18:47 ` Jeremy Allison
2022-11-09 19:24 ` Jeremy Allison
2022-11-09 22:30 ` David Disseldorp
2022-11-10 11:42 ` Christoph Hellwig [this message]
2022-11-10 15:05 ` David Disseldorp
2022-11-09 19:50 ` Amir Goldstein
2022-11-09 21:50 ` David Disseldorp
2022-11-10 11:41 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2zjpE6f6WLtkqiz@infradead.org \
--to=hch@infradead.org \
--cc=amir73il@gmail.com \
--cc=ddiss@samba.org \
--cc=jra@samba.org \
--cc=linux-cifs@vger.kernel.org \
--cc=metze@samba.org \
--cc=samba-technical@lists.samba.org \
--cc=smfrench@gmail.com \
--cc=vl@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox