From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Namjae Jeon <linkinjeon@kernel.org>
Cc: linux-cifs@vger.kernel.org, smfrench@gmail.com,
senozhatsky@chromium.org, tom@talpey.com,
atteh.mailbox@gmail.com
Subject: Re: [PATCH v2] ksmbd-tools: add max connections parameter to global section
Date: Sat, 31 Dec 2022 00:24:56 +0900 [thread overview]
Message-ID: <Y68CyMM/swjY/mhz@google.com> (raw)
In-Reply-To: <20221230142420.10930-1-linkinjeon@kernel.org>
On (22/12/30 23:24), Namjae Jeon wrote:
[..]
> @@ -548,6 +548,16 @@ static gboolean global_group_kv(gpointer _k, gpointer _v, gpointer user_data)
> return TRUE;
> }
>
> + if (!cp_key_cmp(_k, "max connections")) {
> + global_conf.max_connections = memparse(_v);
> + if (global_conf.max_connections > KSMBD_CONF_MAX_CONNECTIONS) {
> + pr_info("Limits exceeding the maximum simultaneous connections(%d)\n",
> + KSMBD_CONF_MAX_CONNECTIONS);
> + global_conf.max_connections = KSMBD_CONF_MAX_CONNECTIONS;
> + }
> + return TRUE;
> + }
A quick question: do you want "max connections = 0" to be possible or
should ksmb never permit unlimited connections?
> + global_conf.max_connections = 512;
> }
[..]
> + share->max_connections = 512;
A nit: may be have a define for default limit instead?
next prev parent reply other threads:[~2022-12-30 15:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-30 14:24 [PATCH v2] ksmbd-tools: add max connections parameter to global section Namjae Jeon
2022-12-30 15:24 ` Sergey Senozhatsky [this message]
2022-12-31 8:21 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y68CyMM/swjY/mhz@google.com \
--to=senozhatsky@chromium.org \
--cc=atteh.mailbox@gmail.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=smfrench@gmail.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox