Re: [PATCH] ksmbd: potential uninitialized error code in set_file_basic_info()

Dan Carpenter
2021-09-07T08:49:29Z

On Tue, Sep 07, 2021 at 05:01:11PM +0900, Sergey Senozhatsky wrote:
>
> rc = setattr_prepare(user_ns, dentry, &attrs);
> if (rc)
> return -EINVAL;
>
> Either it should be used more, and probably be a return value, or we can
> just remove it.

You are looking at old code from before the bug was introduced.

regards,
dan carpenter