From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4448BC433EF for ; Mon, 28 Mar 2022 16:07:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238506AbiC1QIz (ORCPT ); Mon, 28 Mar 2022 12:08:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238285AbiC1QIy (ORCPT ); Mon, 28 Mar 2022 12:08:54 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9AB512C133; Mon, 28 Mar 2022 09:07:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 372436143D; Mon, 28 Mar 2022 16:07:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E3C8C004DD; Mon, 28 Mar 2022 16:07:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648483632; bh=qZVkUhdYVaRCKeRsrsBh1vhZfOiBsQqWGLWkaspWtwI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LTq1BNj7zsS+xlAqljn7dFEkiKHxQ/XlkkYtq9n85qHygOWFP8AGfnFQDi72wOv7A XK6XvHBSgKn8eBdBZC8MJ9F5EeUlDrOD3alotytztzw1+V2DJ6rM+pl1h1shpmUbJ0 ShvKtLShfmTR/+e0g0eJ09i1IIGUdTbHrtrl0p/rtgiXaWD2uMDxdFodatVSPz4Y6H Kau7CTFHNJLA9ssUK9vMAp02adYqYiQ3CkkM2mwnI9xUfNmBr8JQYttyQaQ1KmuaW8 6laQ5sTmkDpHBvtK70ngzBXyyZ+9ngiK0U2mbH/vjMSgYWNih1H2BBMJb8UOQeluN9 2t0pkMBTlv+wQ== Date: Mon, 28 Mar 2022 09:07:05 -0700 From: Nathan Chancellor To: trix@redhat.com Cc: sfrench@samba.org, ndesaulniers@google.com, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] cifs: fix enum usage Message-ID: References: <20220328130300.3090213-1-trix@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220328130300.3090213-1-trix@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org On Mon, Mar 28, 2022 at 06:03:00AM -0700, trix@redhat.com wrote: > From: Tom Rix > > Clang build fails with > cifsfs.c:709:18: error: implicit conversion from enumeration > type 'enum statusEnum' to different enumeration > type 'enum tid_status_enum' > tcon->status = CifsExiting; > ~ ^~~~~~~~~~~ > > The type of the element status changed, so enum needed to change. > Replace CifsExiting with TID_EXITING. Right, this was clearly missed by the below commit, as every other instance of tidStatus was changed to status plus the value from enum tid_status_enum, except this one. > Fixes: 7e5c8c02911b ("smb3: cleanup and clarify status of tree connections") > Signed-off-by: Tom Rix Thanks for sending the patch! Reviewed-by: Nathan Chancellor > --- > fs/cifs/cifsfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c > index 0789bf1496c74..a47fa44b6d52b 100644 > --- a/fs/cifs/cifsfs.c > +++ b/fs/cifs/cifsfs.c > @@ -706,7 +706,7 @@ static void cifs_umount_begin(struct super_block *sb) > spin_unlock(&cifs_tcp_ses_lock); > return; > } else if (tcon->tc_count == 1) > - tcon->status = CifsExiting; > + tcon->status = TID_EXITING; > spin_unlock(&cifs_tcp_ses_lock); > > /* cancel_brl_requests(tcon); */ /* BB mark all brl mids as exiting */ > -- > 2.26.3 > >