From: Christoph Hellwig <hch@infradead.org>
To: Enzo Matsumiya <ematsumiya@suse.de>
Cc: linux-cifs@vger.kernel.org, smfrench@gmail.com, pc@cjr.nz,
ronniesahlberg@gmail.com, nspmangalore@gmail.com
Subject: Re: [RFC PATCH 07/14] cifs: typedef server status enum
Date: Sun, 24 Jul 2022 22:31:17 -0700 [thread overview]
Message-ID: <Yt4qpfUYmmkiHRKl@infradead.org> (raw)
In-Reply-To: <20220724151137.7538-8-ematsumiya@suse.de>
On Sun, Jul 24, 2022 at 12:11:30PM -0300, Enzo Matsumiya wrote:
> typedef "enum statusEnum" to "cifs_server_status_t".
> Rename the status values from CamelCase to snake_case.
Please don't use pointless typedefs for enum. They add no value
at all.
next prev parent reply other threads:[~2022-07-25 5:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-24 15:11 [RFC PATCH 00/14] cifs: rename of several structs and variables Enzo Matsumiya
2022-07-24 15:11 ` [RFC PATCH 01/14] cifs: rename servers list, lock, functions, and vars Enzo Matsumiya
2022-07-24 15:11 ` [RFC PATCH 02/14] cifs: rename xid/mid globals Enzo Matsumiya
2022-07-24 15:11 ` [RFC PATCH 03/14] cifs: rename global counters Enzo Matsumiya
2022-07-24 15:11 ` [RFC PATCH 06/14] cifs: convert server info vars to snake_case Enzo Matsumiya
2022-07-24 15:11 ` [RFC PATCH 07/14] cifs: typedef server status enum Enzo Matsumiya
2022-07-25 5:31 ` Christoph Hellwig [this message]
2022-07-24 15:11 ` [RFC PATCH 08/14] cifs: typedef ses " Enzo Matsumiya
2022-07-24 15:11 ` [RFC PATCH 09/14] cifs: typedef tcon " Enzo Matsumiya
2022-07-24 15:11 ` [RFC PATCH 10/14] cifs: typedef securityEnum Enzo Matsumiya
2022-07-24 15:11 ` [RFC PATCH 11/14] cifs: rename cifsFYI to debug_level Enzo Matsumiya
2022-07-24 15:11 ` [RFC PATCH 12/14] cifs: rename list_head fields Enzo Matsumiya
2022-07-24 15:11 ` [RFC PATCH 14/14] cifs: rename more list_heads, remove redundant prefixes Enzo Matsumiya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yt4qpfUYmmkiHRKl@infradead.org \
--to=hch@infradead.org \
--cc=ematsumiya@suse.de \
--cc=linux-cifs@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=pc@cjr.nz \
--cc=ronniesahlberg@gmail.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox