From: Matthew Wilcox <willy@infradead.org>
To: Jeff Layton <jlayton@kernel.org>
Cc: Enzo Matsumiya <ematsumiya@suse.de>, Tom Talpey <tom@talpey.com>,
linux-cifs@vger.kernel.org, smfrench@gmail.com, pc@cjr.nz,
ronniesahlberg@gmail.com, nspmangalore@gmail.com,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
samba-technical@lists.samba.org, pshilovsky@samba.org
Subject: Re: [RFC PATCH 0/3] Rename "cifs" module to "smbfs"
Date: Thu, 4 Aug 2022 21:23:46 +0100 [thread overview]
Message-ID: <Yuwq0kUJMTAX6F4m@casper.infradead.org> (raw)
In-Reply-To: <cf24d6b5496598e7717428c6bdcb2366a7d49529.camel@kernel.org>
On Thu, Aug 04, 2022 at 03:03:23PM -0400, Jeff Layton wrote:
> On Tue, 2022-08-02 at 22:56 -0300, Enzo Matsumiya wrote:
> > On 08/02, Tom Talpey wrote:
> > > The initial goal is to modularize the SMB1 code, so it can be completely
> > > removed from a running system. The extensive refactoring logically leads
> > > to this directory renaming, but renaming is basically a side effect.
> > >
>
> This is a great technical goal. Splitting up cifs.ko into smaller
> modules would be great, in addition to being able to turn off smb1
> support.
I don't know the CIFS module that well. How do you see it being split
up? It's #4 in the list of filesystems:
$ size /lib/modules/5.18.0-3-amd64/kernel/fs/*/*.ko |sort -n |tail
369020 28460 132 397612 6112c /lib/modules/5.18.0-3-amd64/kernel/fs/ubifs/ubifs.ko
395793 50398 960 447151 6d2af /lib/modules/5.18.0-3-amd64/kernel/fs/ceph/ceph.ko
477909 58883 10512 547304 859e8 /lib/modules/5.18.0-3-amd64/kernel/fs/nfsd/nfsd.ko
609260 84848 640 694748 a99dc /lib/modules/5.18.0-3-amd64/kernel/fs/f2fs/f2fs.ko
622638 252078 1008 875724 d5ccc /lib/modules/5.18.0-3-amd64/kernel/fs/nfs/nfsv4.ko
717343 111314 1176 829833 ca989 /lib/modules/5.18.0-3-amd64/kernel/fs/ext4/ext4.ko
884247 206051 504 1090802 10a4f2 /lib/modules/5.18.0-3-amd64/kernel/fs/cifs/cifs.ko
890155 159520 240 1049915 10053b /lib/modules/5.18.0-3-amd64/kernel/fs/ocfs2/ocfs2.ko
1193834 274148 456 1468438 166816 /lib/modules/5.18.0-3-amd64/kernel/fs/xfs/xfs.ko
1393088 126501 15072 1534661 176ac5 /lib/modules/5.18.0-3-amd64/kernel/fs/btrfs/btrfs.ko
... but if you look at how NFS is split up:
311322 76200 392 387914 5eb4a /lib/modules/5.18.0-3-amd64/kernel/fs/nfs/nfs.ko
25157 1100 72 26329 66d9 /lib/modules/5.18.0-3-amd64/kernel/fs/nfs/nfsv2.ko
49332 1544 120 50996 c734 /lib/modules/5.18.0-3-amd64/kernel/fs/nfs/nfsv3.ko
622638 252078 1008 875724 d5ccc /lib/modules/5.18.0-3-amd64/kernel/fs/nfs/nfsv4.ko
you can save a lot of RAM if you don't need NFSv4 (then there's also
nfs_common, 408kB of sunrpc.ko, etc, etc).
next prev parent reply other threads:[~2022-08-04 20:23 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 19:09 [RFC PATCH 0/3] Rename "cifs" module to "smbfs" Enzo Matsumiya
2022-08-01 19:09 ` [RFC PATCH 1/3] cifs: change module name to "smbfs.ko" Enzo Matsumiya
2023-07-26 20:28 ` Steve French
2023-07-26 20:29 ` Steve French
2023-07-26 20:31 ` Steve French
2022-08-01 19:09 ` [RFC PATCH 2/3] smbfs: rename directory "fs/cifs" -> "fs/smbfs" Enzo Matsumiya
2022-08-01 19:09 ` [RFC PATCH 3/3] smbfs: update doc references Enzo Matsumiya
2022-08-01 19:58 ` [RFC PATCH 0/3] Rename "cifs" module to "smbfs" Rowland Penny
2022-08-01 20:14 ` Enzo Matsumiya
2022-08-01 20:27 ` Steve French
2022-08-01 20:41 ` Enzo Matsumiya
2022-08-02 0:38 ` Tom Talpey
2022-08-02 0:42 ` Steve French
2022-08-02 13:52 ` Enzo Matsumiya
2022-08-02 15:35 ` Steve French
2022-08-02 15:58 ` Enzo Matsumiya
2022-08-02 16:20 ` Steve French
2022-08-02 17:43 ` Tom Talpey
2022-08-02 14:42 ` Jeff Layton
2022-08-02 19:36 ` Enzo Matsumiya
2022-08-02 20:07 ` Jeff Layton
2022-08-03 1:32 ` Tom Talpey
2022-08-03 1:56 ` Enzo Matsumiya
2022-08-04 19:03 ` Jeff Layton
2022-08-04 20:23 ` Matthew Wilcox [this message]
2022-08-04 20:48 ` Jeff Layton
2022-08-03 5:38 ` Steve French
2022-08-03 14:45 ` Enzo Matsumiya
2022-08-03 17:50 ` Paulo Alcantara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yuwq0kUJMTAX6F4m@casper.infradead.org \
--to=willy@infradead.org \
--cc=ematsumiya@suse.de \
--cc=jlayton@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=pc@cjr.nz \
--cc=pshilovsky@samba.org \
--cc=ronniesahlberg@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=smfrench@gmail.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox