From: Jeremy Allison <jra@samba.org>
To: atheik <atteh.mailbox@gmail.com>
Cc: hyc.lee@gmail.com, linkinjeon@kernel.org,
linux-cifs@vger.kernel.org, senozhatsky@chromium.org,
smfrench@gmail.com, tom@talpey.com
Subject: Re: [PATCH 1/2] ksmbd: update documentation
Date: Thu, 1 Sep 2022 11:30:32 -0700 [thread overview]
Message-ID: <YxD6SEN9/3rEWaNR@jeremy-acer> (raw)
In-Reply-To: <20220901174108.24621-1-atteh.mailbox@gmail.com>
On Thu, Sep 01, 2022 at 08:41:08PM +0300, atheik wrote:
>On Thu, 1 Sep 2022 09:14:31 -0700, Jeremy Allison wrote:
>>On Thu, Sep 01, 2022 at 09:06:07AM -0400, Tom Talpey wrote:
>>>
>>>Ok, two things. What I found strange is the "man smb.conf.5ksmbd", and
>>>as you say that should be man 5k smb.conf. Sounds ok to me.
>>>
>>>But the second thing I'm concerned about is the reuse of the smb.conf
>>>filename. It's perfectly possible to install both Samba and ksmbd on
>>>a system, they can be configured to use different ports, listen on
>>>different interfaces, or any number of other deployment approaches.
>>>
>>>And, Samba provides MUCH more than an SMB server, and configures many
>>>other services in smb.conf. So I feel ksmbd should avoid such filename
>>>conflicts. To me, calling it "ksmbd.conf" is much more logical.
>>
>>+1 from me. Having 2 conflicting file contents both wanting
>>to be called smb.conf is a disaster waiting to happen.
>
>ksmbd-tools clearly has a goal of being compatible with smb.conf(5) of
>Samba when it comes to the common subset of functionality they share.
>ksmbd-tools has 7 global parameters that Samba does not have, but other
>than, share parameters and global parameters of ksmbd-tools are subset
>of those in Samba. Samba and ksmbd-tools do not have any conflicting
>file locations. The smb.conf(5ksmbd) man page of ksmbd-tools does not
>collide with and never overshadows smb.conf(5) of Samba. Please, help
>me understand what sort of disaster this could lead to.
Samba adds and or changes functionality in smb.conf all
the time, without coordination with ksmbd. If you call
your config file smb.conf then we would have to coordinate
with you before any changes.
Over time, the meaning/use/names of parameters will drift
apart leading to possible conflicts.
Plus it leads to massive user confusion (am I running
smbd or ksmbd ? How do I tell ? etc.).
It is simple hygene to keep these names separate.
Please do so.
next prev parent reply other threads:[~2022-09-01 18:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 14:17 [PATCH 1/2] ksmbd: update documentation Namjae Jeon
2022-08-30 14:17 ` [PATCH 2/2] ksmbd: remove generic_fillattr use in smb2_open() Namjae Jeon
2022-09-01 6:08 ` Hyunchul Lee
2022-08-30 16:13 ` [PATCH 1/2] ksmbd: update documentation Tom Talpey
2022-08-31 1:36 ` Namjae Jeon
2022-09-01 5:19 ` atheik
2022-09-01 13:06 ` Tom Talpey
2022-09-01 16:14 ` Jeremy Allison
2022-09-01 17:41 ` atheik
2022-09-01 18:30 ` Jeremy Allison [this message]
2022-09-01 18:52 ` Tom Talpey
2022-09-01 22:24 ` Steve French
2022-09-01 23:54 ` Tom Talpey
2022-09-01 19:42 ` atheik
2022-09-01 20:26 ` Jeremy Allison
2022-09-01 21:21 ` ronnie sahlberg
2022-09-01 21:37 ` Steve French
2022-09-01 21:48 ` Jeremy Allison
2022-09-02 0:56 ` Namjae Jeon
2022-09-02 2:11 ` Jeremy Allison
2022-09-02 12:35 ` Tom Talpey
2022-09-02 13:33 ` Namjae Jeon
2022-08-30 17:32 ` Tom Talpey
2022-08-31 0:02 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxD6SEN9/3rEWaNR@jeremy-acer \
--to=jra@samba.org \
--cc=atteh.mailbox@gmail.com \
--cc=hyc.lee@gmail.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=senozhatsky@chromium.org \
--cc=smfrench@gmail.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox