From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Tom Talpey <tom@talpey.com>
Cc: Namjae Jeon <linkinjeon@kernel.org>,
linux-cifs@vger.kernel.org, smfrench@gmail.com,
senozhatsky@chromium.org, atteh.mailbox@gmail.com
Subject: Re: [PATCH] ksmbd: hide socket error message when ipv6 config is disable
Date: Thu, 29 Sep 2022 11:08:20 +0900 [thread overview]
Message-ID: <YzT+FFwTmcvjppVc@google.com> (raw)
In-Reply-To: <60322098-648f-2610-bcf2-1cec581d4f86@talpey.com>
On (22/09/28 11:25), Tom Talpey wrote:
> > diff --git a/fs/ksmbd/transport_tcp.c b/fs/ksmbd/transport_tcp.c
> > index 143bba4e4db8..9b35afcdcf0d 100644
> > --- a/fs/ksmbd/transport_tcp.c
> > +++ b/fs/ksmbd/transport_tcp.c
> > @@ -399,7 +399,8 @@ static int create_socket(struct interface *iface)
> > ret = sock_create(PF_INET6, SOCK_STREAM, IPPROTO_TCP, &ksmbd_socket);
> > if (ret) {
> > - pr_err("Can't create socket for ipv6, try ipv4: %d\n", ret);
> > + if (ret != -EAFNOSUPPORT)
> > + pr_err("Can't create socket for ipv6, try ipv4: %d\n", ret);
>
> Why not just eliminate the splat? The only real error seems to be
> that IPv6 is not configured, which is undoubtedly intentional, and
> in any case there's nothing to do about it. Suggesting to "try ipv4"
> is kind of pointless, isn't it?
Yeah, that pr_err() sounds like a suggestion, but in fact it's not.
It meant to say "ipv6 socket creation failed, fallback to ipv4".
next prev parent reply other threads:[~2022-09-29 2:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 21:51 [PATCH] ksmbd: hide socket error message when ipv6 config is disable Namjae Jeon
2022-09-28 15:25 ` Tom Talpey
2022-09-28 23:44 ` Namjae Jeon
2022-09-29 15:37 ` Tom Talpey
2022-09-29 2:08 ` Sergey Senozhatsky [this message]
2022-09-29 2:48 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzT+FFwTmcvjppVc@google.com \
--to=senozhatsky@chromium.org \
--cc=atteh.mailbox@gmail.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=smfrench@gmail.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox