From: Samuel Cabrero <scabrero@suse.de>
To: "Aurélien Aptel" <aaptel@suse.com>, linux-cifs@vger.kernel.org
Cc: smfrench@gmail.com, scabrero@suse.com
Subject: Re: [PATCH v1] cifs: simplify SWN code with dummy funcs instead of ifdefs
Date: Wed, 24 Mar 2021 09:57:27 +0100 [thread overview]
Message-ID: <a07bc171d986e75f7edb9cf0fe842fa8c8e44892.camel@suse.de> (raw)
In-Reply-To: <20210318175531.30565-1-aaptel@suse.com>
On Thu, 2021-03-18 at 18:55 +0100, Aurélien Aptel wrote:
> From: Aurelien Aptel <aaptel@suse.com>
>
> This commit doesn't change the logic of SWN.
>
> Add dummy implementation of SWN functions when SWN is disabled instead
> of using ifdef sections.
>
> The dummy functions get optimized out, this leads to clearer code and
> compile time type-checking regardless of config options with no
> runtime penalty.
>
> Leave the simple ifdefs section as-is.
>
> A single bitfield (bool foo:1) on its own will use up one int. Move
> tcon->use_witness out of ifdefs with the other tcon bitfields.
>
> Signed-off-by: Aurelien Aptel <aaptel@suse.com>
Thanks Aurelien, it LGTM.
Reviewed-by: Samuel Cabrero <scabrero@suse.de>
--
Samuel Cabrero / SUSE Labs Samba Team
GPG: D7D6 E259 F91C F0B3 2E61 1239 3655 6EC9 7051 0856
scabrero@suse.com
scabrero@suse.de
next prev parent reply other threads:[~2021-03-24 8:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 17:55 [PATCH v1] cifs: simplify SWN code with dummy funcs instead of ifdefs Aurélien Aptel
2021-03-24 8:57 ` Samuel Cabrero [this message]
2021-04-09 4:28 ` Steve French
2021-04-09 14:31 ` [PATCH v2] " Aurélien Aptel
2021-04-09 18:49 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a07bc171d986e75f7edb9cf0fe842fa8c8e44892.camel@suse.de \
--to=scabrero@suse.de \
--cc=aaptel@suse.com \
--cc=linux-cifs@vger.kernel.org \
--cc=scabrero@suse.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox