From: Enzo Matsumiya <ematsumiya@suse.de>
To: Shyam Prasad N <nspmangalore@gmail.com>
Cc: linux-cifs@vger.kernel.org, smfrench@gmail.com, pc@manguebit.org,
bharathsm@microsoft.com, dhowells@redhat.com,
henrique.carvalho@suse.com,
Shyam Prasad N <sprasad@microsoft.com>
Subject: Re: [PATCH v5 16/17] cifs: keep cfids in rbtree for efficient lookups
Date: Sun, 17 May 2026 21:42:28 +0200 [thread overview]
Message-ID: <agoVi61qbemLWd0i@suse.de> (raw)
In-Reply-To: <CANT5p=r9k5AMMOGiX2M_ZYPBDD7LnLX_vXh6tOKBnMeyqbt8NQ@mail.gmail.com>
On 05/15, Shyam Prasad N wrote:
>On Fri, May 15, 2026 at 2:13 AM Enzo Matsumiya <ematsumiya@suse.de> wrote:
>>
>> Hi Shyam,
>>
>
>Hi Enzo,
>Thanks for the review.
>
>> On 05/14, nspmangalore@gmail.com wrote:
>> >From: Shyam Prasad N <sprasad@microsoft.com>
>> >
>> >Today tcon->cfids are maintained as a linked list. When we do
>> >not limit the number of cfids (limited by system memory), this
>> >can be a problem if the mount has a large number of active dir
>> >accesses. We soon start hitting perf bottlenecks.
>>
>> Do you have performance results on your list vs rbtree tests?
>
>Not specifically for this. But I ran benchmarks with a file containing
>100k dentries, and compared the numbers with and without the whole
>patch set. Performance has not regressed.
Interesting, I'll try out this series when I have more time (not this
week) -- I need to dig the tests I was doing back then that got me into
those obstacles I mention.
>> I tried this exact same change a few months ago, and my experience was
>> that, under a stress test (e.g. dbench), performance was severely
>> degraded with the rbtree version because of the many rebalances
>> (e.g. too many lease breaks causing rbtree erases).
>
>Interesting. Will run dbench with the changes and check. Do you have
>the dbench configuration you used?
xfstests generic/241 should be enough, or if on a too fast/slow
machine/network, try playing around with the parameters from that test
(it uses "dbench -t 60 -D $TEST_DIR/dbench 4" hardcoded)
>> I'd be happy to hear this changed since then (with all cached dir fixes
>> that came in) -- I have several improvement ideas to apply on top of
>> the rbtree solution :)
>>
>
>Happy to hear out the ideas. :)
>Let's target the next rc1 to make significant perf gains with dir leases.
>
>>
>> A quick observation for this patch inlined below.
>>
>> >This change stores cfids in a rbtree instead of a linked list.
>> >The nodes of this tree are keyed based on the path inside the tcon.
>> >
>> >Additionally, for faster lookups by dentry, introducing a hashtable
>> >to allow lookups of cfids by dentry faster. This is important
>> >since open_cached_dir_by_dentry is called quite frequently.
>> >
>> >Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>
>> >---
>> > fs/smb/client/cached_dir.c | 227 ++++++++++++++++++++++++++-----------
>> > fs/smb/client/cached_dir.h | 8 +-
>> > fs/smb/client/cifs_debug.c | 4 +-
>> > 3 files changed, 172 insertions(+), 67 deletions(-)
>> >
>> >diff --git a/fs/smb/client/cached_dir.c b/fs/smb/client/cached_dir.c
>> >index 389695b203247..3cf4cfa23c377 100644
>> >--- a/fs/smb/client/cached_dir.c
>> >+++ b/fs/smb/client/cached_dir.c
>> >@@ -22,6 +22,7 @@ static void smb2_close_cached_fid(struct kref *ref);
>> > static void cfids_laundromat_worker(struct work_struct *work);
>> >
>> > #define CACHED_DIRENT_HASH_BITS 7
>> >+#define CACHED_DIR_DENTRY_HT_BITS 8
>> >
>> > struct cached_dir_dentry {
>> > struct list_head entry;
>> >@@ -1239,6 +1240,57 @@ int cifs_wait_for_pending_dcache(struct cached_fid *cfid,
>> > return ret;
>> > }
>> >
>> >+static struct cached_fid *cfid_rb_find(struct rb_root *root, const char *path)
>> >+{
>> >+ struct rb_node *node = root->rb_node;
>> >+
>> >+ while (node) {
>> >+ struct cached_fid *cfid = rb_entry(node, struct cached_fid, node);
>> >+ int cmp = strcmp(path, cfid->path);
>> >+
>> >+ if (cmp < 0)
>> >+ node = node->rb_left;
>> >+ else if (cmp > 0)
>> >+ node = node->rb_right;
>> >+ else
>> >+ return cfid;
>> >+ }
>> >+ return NULL;
>> >+}
>> >+
>> >+static struct cached_fid *cfid_dentry_ht_find(struct cached_fids *cfids,
>> >+ struct dentry *dentry)
>> >+{
>> >+ struct cached_fid *cfid;
>> >+
>> >+ hlist_for_each_entry(cfid,
>> >+ &cfids->dentry_ht[hash_ptr(dentry, CACHED_DIR_DENTRY_HT_BITS)],
>> >+ dentry_node) {
>> >+ if (cfid->dentry == dentry)
>> >+ return cfid;
>> >+ }
>> >+ return NULL;
>> >+}
>> >+
>> >+static void cfid_rb_insert(struct rb_root *root, struct cached_fid *new)
>> >+{
>> >+ struct rb_node **link = &root->rb_node;
>> >+ struct rb_node *parent = NULL;
>> >+
>> >+ while (*link) {
>> >+ struct cached_fid *cfid = rb_entry(*link, struct cached_fid, node);
>> >+ int cmp = strcmp(new->path, cfid->path);
>> >+
>> >+ parent = *link;
>> >+ if (cmp < 0)
>> >+ link = &(*link)->rb_left;
>> >+ else
>> >+ link = &(*link)->rb_right;
>> >+ }
>> >+ rb_link_node(&new->node, parent, link);
>> >+ rb_insert_color(&new->node, root);
>> >+}
>> >+
>>
>> There's rb_find() and rb_add() already, and I really think you should
>> use them -- no duplicate code -> less cifs-maintained code, thus less
>> chance for bugs.
>> It would only require 2 (bool/int) "cfid_cmp()" helpers to do strcmp()
>> (if you structure it well enough, it might even be possible to do some
>> validation/skipping within the compare functions).
>
>I see. Let me work on this next week.
>
>>
>> > static struct cached_fid *find_or_create_cached_dir(struct cached_fids *cfids,
>> > const char *path,
>> > bool lookup_only,
>> >@@ -1246,22 +1298,21 @@ static struct cached_fid *find_or_create_cached_dir(struct cached_fids *cfids,
>> > {
>> > struct cached_fid *cfid;
>> >
>> >- list_for_each_entry(cfid, &cfids->entries, entry) {
>> >- if (!strcmp(cfid->path, path)) {
>> >- /*
>> >- * If it doesn't have a lease it is either not yet
>> >- * fully cached or it may be in the process of
>> >- * being deleted due to a lease break.
>> >- */
>> >- spin_lock(&cfid->cfid_lock);
>> >- if (!is_valid_cached_dir(cfid)) {
>> >- spin_unlock(&cfid->cfid_lock);
>> >- return NULL;
>> >- }
>> >- kref_get(&cfid->refcount);
>> >+ cfid = cfid_rb_find(&cfids->entries, path);
>> >+ if (cfid) {
>> >+ /*
>> >+ * If it doesn't have a lease it is either not yet
>> >+ * fully cached or it may be in the process of
>> >+ * being deleted due to a lease break.
>> >+ */
>> >+ spin_lock(&cfid->cfid_lock);
>> >+ if (!is_valid_cached_dir(cfid)) {
>> > spin_unlock(&cfid->cfid_lock);
>> >- return cfid;
>> >+ return NULL;
>> > }
>> >+ kref_get(&cfid->refcount);
>> >+ spin_unlock(&cfid->cfid_lock);
>> >+ return cfid;
>> > }
>> > if (lookup_only) {
>> > return NULL;
>> >@@ -1276,7 +1327,7 @@ static struct cached_fid *find_or_create_cached_dir(struct cached_fids *cfids,
>> > }
>> > cfid->cfids = cfids;
>> > cfids->num_entries++;
>> >- list_add(&cfid->entry, &cfids->entries);
>> >+ cfid_rb_insert(&cfids->entries, cfid);
>> > cfid->on_list = true;
>> > kref_get(&cfid->refcount);
>> > /*
>> >@@ -1458,26 +1509,30 @@ int open_cached_dir(unsigned int xid, struct cifs_tcon *tcon,
>> > struct cached_fid *parent_cfid;
>> >
>> > spin_lock(&cfids->cfid_list_lock);
>> >- list_for_each_entry(parent_cfid, &cfids->entries, entry) {
>> >+ hlist_for_each_entry(parent_cfid,
>> >+ &cfids->dentry_ht[hash_ptr(dentry->d_parent,
>> >+ CACHED_DIR_DENTRY_HT_BITS)],
>> >+ dentry_node) {
>> >+ if (parent_cfid->dentry != dentry->d_parent)
>> >+ continue;
>> > spin_lock(&parent_cfid->cfid_lock);
>> >- if (parent_cfid->dentry == dentry->d_parent) {
>> >- cifs_dbg(FYI, "found a parent cached file handle\n");
>> >- if (is_valid_cached_dir(parent_cfid)) {
>> >- lease_flags
>> >- |= SMB2_LEASE_FLAG_PARENT_LEASE_KEY_SET_LE;
>> >- memcpy(pfid->parent_lease_key,
>> >- parent_cfid->fid.lease_key,
>> >- SMB2_LEASE_KEY_SIZE);
>> >- }
>> >- spin_unlock(&parent_cfid->cfid_lock);
>> >- break;
>> >+ cifs_dbg(FYI, "found a parent cached file handle\n");
>> >+ if (is_valid_cached_dir(parent_cfid)) {
>> >+ lease_flags
>> >+ |= SMB2_LEASE_FLAG_PARENT_LEASE_KEY_SET_LE;
>> >+ memcpy(pfid->parent_lease_key,
>> >+ parent_cfid->fid.lease_key,
>> >+ SMB2_LEASE_KEY_SIZE);
>> > }
>> > spin_unlock(&parent_cfid->cfid_lock);
>> >+ break;
>> > }
>> > spin_unlock(&cfids->cfid_list_lock);
>> > }
>> > }
>> > cfid->dentry = dentry;
>> >+ hlist_add_head(&cfid->dentry_node,
>> >+ &cfids->dentry_ht[hash_ptr(dentry, CACHED_DIR_DENTRY_HT_BITS)]);
>> > cfid->tcon = tcon;
>> >
>> > /*
>> >@@ -1630,7 +1685,9 @@ int open_cached_dir(unsigned int xid, struct cifs_tcon *tcon,
>> >
>> > spin_lock(&cfids->cfid_list_lock);
>> > if (cfid->on_list) {
>> >- list_del(&cfid->entry);
>> >+ if (cfid->dentry)
>> >+ hlist_del_init(&cfid->dentry_node);
>> >+ rb_erase(&cfid->node, &cfids->entries);
>> > cfid->on_list = false;
>> > cfids->num_entries--;
>> > }
>> >@@ -1674,26 +1731,28 @@ int open_cached_dir_by_dentry(struct cifs_tcon *tcon,
>> > return -ENOENT;
>> >
>> > spin_lock(&cfids->cfid_list_lock);
>> >- list_for_each_entry(cfid, &cfids->entries, entry) {
>> >- if (cfid->dentry == dentry) {
>> >- spin_lock(&cfid->cfid_lock);
>> >- if (!is_valid_cached_dir(cfid)) {
>> >- spin_unlock(&cfid->cfid_lock);
>> >- rc = -ENOENT;
>> >- break;
>> >- }
>> >- cifs_dbg(FYI, "found a cached file handle by dentry\n");
>> >- kref_get(&cfid->refcount);
>> >- *ret_cfid = cfid;
>> >- cfid->last_access_time = jiffies;
>> >- rc = 0;
>> >- trace_cfid = cfid;
>> >+ cfid = cfid_dentry_ht_find(cfids, dentry);
>> >+ if (cfid) {
>> >+ spin_lock(&cfid->cfid_lock);
>> >+ if (!is_valid_cached_dir(cfid)) {
>> > spin_unlock(&cfid->cfid_lock);
>> > spin_unlock(&cfids->cfid_list_lock);
>> >- trace_smb3_open_cached_dir_by_dentry(cfid, dentry->d_name.name,
>> >- dentry->d_name.len, 0);
>> >+ trace_smb3_open_cached_dir_by_dentry(cfid,
>> >+ dentry->d_name.name,
>> >+ dentry->d_name.len, rc);
>> > return rc;
>> > }
>> >+ cifs_dbg(FYI, "found a cached file handle by dentry\n");
>> >+ kref_get(&cfid->refcount);
>> >+ *ret_cfid = cfid;
>> >+ cfid->last_access_time = jiffies;
>> >+ rc = 0;
>> >+ spin_unlock(&cfid->cfid_lock);
>> >+ spin_unlock(&cfids->cfid_list_lock);
>> >+ trace_smb3_open_cached_dir_by_dentry(cfid,
>> >+ dentry->d_name.name,
>> >+ dentry->d_name.len, rc);
>> >+ return rc;
>> > }
>> > spin_unlock(&cfids->cfid_list_lock);
>> > trace_smb3_open_cached_dir_by_dentry(NULL, dentry->d_name.name,
>> >@@ -1715,7 +1774,9 @@ __releases(&cfid->cfids->cfid_list_lock)
>> > lockdep_assert_held(&cfid->cfids->cfid_list_lock);
>> >
>> > if (cfid->on_list) {
>> >- list_del(&cfid->entry);
>> >+ if (cfid->dentry)
>> >+ hlist_del_init(&cfid->dentry_node);
>> >+ rb_erase(&cfid->node, &cfid->cfids->entries);
>> > cfid->on_list = false;
>> > cfid->cfids->num_entries--;
>> > }
>> >@@ -1790,6 +1851,7 @@ void close_all_cached_dirs(struct cifs_sb_info *cifs_sb)
>> > {
>> > struct rb_root *root = &cifs_sb->tlink_tree;
>> > struct rb_node *node;
>> >+ struct rb_node *cfid_node;
>> > struct cached_fid *cfid;
>> > struct cifs_tcon *tcon;
>> > struct tcon_link *tlink;
>> >@@ -1807,7 +1869,9 @@ void close_all_cached_dirs(struct cifs_sb_info *cifs_sb)
>> > if (cfids == NULL)
>> > continue;
>> > spin_lock(&cfids->cfid_list_lock);
>> >- list_for_each_entry(cfid, &cfids->entries, entry) {
>> >+ for (cfid_node = rb_first(&cfids->entries);
>> >+ cfid_node; cfid_node = rb_next(cfid_node)) {
>> >+ cfid = rb_entry(cfid_node, struct cached_fid, node);
>> > tmp_list = kmalloc_obj(*tmp_list, GFP_ATOMIC);
>> > if (tmp_list == NULL) {
>> > /*
>> >@@ -1823,6 +1887,7 @@ void close_all_cached_dirs(struct cifs_sb_info *cifs_sb)
>> >
>> > spin_lock(&cfid->cfid_lock);
>> > tmp_list->dentry = cfid->dentry;
>> >+ hlist_del_init(&cfid->dentry_node);
>> > cfid->dentry = NULL;
>> > spin_unlock(&cfid->cfid_lock);
>> >
>> >@@ -1850,7 +1915,8 @@ void close_all_cached_dirs(struct cifs_sb_info *cifs_sb)
>> > void invalidate_all_cached_dirs(struct cifs_tcon *tcon, bool sync)
>> > {
>> > struct cached_fids *cfids = tcon->cfids;
>> >- struct cached_fid *cfid, *q;
>> >+ struct cached_fid *cfid;
>> >+ struct rb_node *rb_node = NULL, *next_node = NULL;
>> >
>> > if (cfids == NULL)
>> > return;
>> >@@ -1861,8 +1927,14 @@ void invalidate_all_cached_dirs(struct cifs_tcon *tcon, bool sync)
>> > * during this process.
>> > */
>> > spin_lock(&cfids->cfid_list_lock);
>> >- list_for_each_entry_safe(cfid, q, &cfids->entries, entry) {
>> >- list_move(&cfid->entry, &cfids->dying);
>> >+ for (rb_node = rb_first(&cfids->entries);
>> >+ rb_node; rb_node = next_node) {
>> >+ next_node = rb_next(rb_node);
>> >+ cfid = rb_entry(rb_node, struct cached_fid, node);
>> >+ if (cfid->dentry)
>> >+ hlist_del_init(&cfid->dentry_node);
>> >+ rb_erase(rb_node, &cfids->entries);
>> >+ list_add(&cfid->dying_entry, &cfids->dying);
>> > cfids->num_entries--;
>> > spin_lock(&cfid->cfid_lock);
>> > cfid->is_open = false;
>> >@@ -1926,7 +1998,9 @@ bool cached_dir_lease_break(struct cifs_tcon *tcon, __u8 lease_key[16])
>> > return false;
>> >
>> > spin_lock(&cfids->cfid_list_lock);
>> >- list_for_each_entry(cfid, &cfids->entries, entry) {
>> >+ for (struct rb_node *rb_node = rb_first(&cfids->entries);
>> >+ rb_node; rb_node = rb_next(rb_node)) {
>> >+ cfid = rb_entry(rb_node, struct cached_fid, node);
>> > spin_lock(&cfid->cfid_lock);
>> > if (cfid->has_lease &&
>> > !memcmp(lease_key,
>> >@@ -1939,7 +2013,9 @@ bool cached_dir_lease_break(struct cifs_tcon *tcon, __u8 lease_key[16])
>> > * We found a lease remove it from the list
>> > * so no threads can access it.
>> > */
>> >- list_del(&cfid->entry);
>> >+ if (cfid->dentry)
>> >+ hlist_del_init(&cfid->dentry_node);
>> >+ rb_erase(rb_node, &cfids->entries);
>> > cfid->on_list = false;
>> > cfids->num_entries--;
>> >
>> >@@ -1971,7 +2047,9 @@ static struct cached_fid *init_cached_dir(const char *path)
>> >
>> > INIT_WORK(&cfid->close_work, cached_dir_offload_close);
>> > INIT_WORK(&cfid->put_work, cached_dir_put_work);
>> >- INIT_LIST_HEAD(&cfid->entry);
>> >+ RB_CLEAR_NODE(&cfid->node);
>> >+ INIT_HLIST_NODE(&cfid->dentry_node);
>> >+ INIT_LIST_HEAD(&cfid->dying_entry);
>> > INIT_LIST_HEAD(&cfid->dirents.entry_list);
>> > mutex_init(&cfid->dirents.de_mutex);
>> > mutex_init(&cfid->cfid_open_mutex);
>> >@@ -2026,14 +2104,20 @@ static void cfids_laundromat_worker(struct work_struct *work)
>> >
>> > spin_lock(&cfids->cfid_list_lock);
>> > /* move cfids->dying to the local list */
>> >- list_cut_before(&entry, &cfids->dying, &cfids->dying);
>> >+ list_splice_init(&cfids->dying, &entry);
>> >
>> >- list_for_each_entry_safe(cfid, q, &cfids->entries, entry) {
>> >+ for (struct rb_node *rb_node = rb_first(&cfids->entries), *next_node;
>> >+ rb_node; rb_node = next_node) {
>> >+ next_node = rb_next(rb_node);
>> >+ cfid = rb_entry(rb_node, struct cached_fid, node);
>> > spin_lock(&cfid->cfid_lock);
>> > if (dir_cache_timeout && cfid->last_access_time &&
>> > time_after(jiffies, cfid->last_access_time + HZ * dir_cache_timeout)) {
>> > cfid->on_list = false;
>> >- list_move(&cfid->entry, &entry);
>> >+ if (cfid->dentry)
>> >+ hlist_del_init(&cfid->dentry_node);
>> >+ rb_erase(rb_node, &cfids->entries);
>> >+ list_add(&cfid->dying_entry, &entry);
>> > cfids->num_entries--;
>> > if (cfid->has_lease) {
>> > /*
>> >@@ -2052,8 +2136,8 @@ static void cfids_laundromat_worker(struct work_struct *work)
>> > }
>> > spin_unlock(&cfids->cfid_list_lock);
>> >
>> >- list_for_each_entry_safe(cfid, q, &entry, entry) {
>> >- list_del(&cfid->entry);
>> >+ list_for_each_entry_safe(cfid, q, &entry, dying_entry) {
>> >+ list_del(&cfid->dying_entry);
>> >
>> > dput(cfid->dentry);
>> > cfid->dentry = NULL;
>> >@@ -2085,7 +2169,13 @@ struct cached_fids *init_cached_dirs(void)
>> > if (!cfids)
>> > return NULL;
>> > spin_lock_init(&cfids->cfid_list_lock);
>> >- INIT_LIST_HEAD(&cfids->entries);
>> >+ cfids->entries = RB_ROOT;
>> >+ cfids->dentry_ht = kcalloc(1 << CACHED_DIR_DENTRY_HT_BITS,
>> >+ sizeof(*cfids->dentry_ht), GFP_KERNEL);
>> >+ if (!cfids->dentry_ht) {
>> >+ kfree(cfids);
>> >+ return NULL;
>> >+ }
>> > INIT_LIST_HEAD(&cfids->dying);
>> >
>> > INIT_DELAYED_WORK(&cfids->laundromat_work, cfids_laundromat_worker);
>> >@@ -2113,25 +2203,34 @@ void free_cached_dirs(struct cached_fids *cfids)
>> >
>> > cancel_delayed_work_sync(&cfids->laundromat_work);
>> >
>> >+ kfree(cfids->dentry_ht);
>> >+ cfids->dentry_ht = NULL;
>> >+
>> > spin_lock(&cfids->cfid_list_lock);
>> >- list_for_each_entry_safe(cfid, q, &cfids->entries, entry) {
>> >+ for (struct rb_node *rb_node = rb_first(&cfids->entries), *next_node;
>> >+ rb_node; rb_node = next_node) {
>> >+ next_node = rb_next(rb_node);
>> >+ cfid = rb_entry(rb_node, struct cached_fid, node);
>> > cfid->on_list = false;
>> >+ if (cfid->dentry)
>> >+ hlist_del_init(&cfid->dentry_node);
>> > spin_lock(&cfid->cfid_lock);
>> > cfid->is_open = false;
>> > spin_unlock(&cfid->cfid_lock);
>> >- list_move(&cfid->entry, &entry);
>> >+ rb_erase(rb_node, &cfids->entries);
>> >+ list_add(&cfid->dying_entry, &entry);
>> > }
>> >- list_for_each_entry_safe(cfid, q, &cfids->dying, entry) {
>> >+ list_for_each_entry_safe(cfid, q, &cfids->dying, dying_entry) {
>> > cfid->on_list = false;
>> > spin_lock(&cfid->cfid_lock);
>> > cfid->is_open = false;
>> > spin_unlock(&cfid->cfid_lock);
>> >- list_move(&cfid->entry, &entry);
>> >+ list_move(&cfid->dying_entry, &entry);
>> > }
>> > spin_unlock(&cfids->cfid_list_lock);
>> >
>> >- list_for_each_entry_safe(cfid, q, &entry, entry) {
>> >- list_del(&cfid->entry);
>> >+ list_for_each_entry_safe(cfid, q, &entry, dying_entry) {
>> >+ list_del(&cfid->dying_entry);
>> > free_cached_dir(cfid);
>> > }
>> >
>> >diff --git a/fs/smb/client/cached_dir.h b/fs/smb/client/cached_dir.h
>> >index 9226463000499..4091fa7867618 100644
>> >--- a/fs/smb/client/cached_dir.h
>> >+++ b/fs/smb/client/cached_dir.h
>> >@@ -11,6 +11,7 @@
>> > #include <linux/completion.h>
>> > #include <linux/build_bug.h>
>> > #include <linux/list.h>
>> >+#include <linux/rbtree.h>
>> > #include <linux/netfs.h>
>> >
>> > struct cifs_search_info;
>> >@@ -139,7 +140,9 @@ struct cached_dirents {
>> > };
>> >
>> > struct cached_fid {
>> >- struct list_head entry;
>> >+ struct rb_node node;
>> >+ struct hlist_node dentry_node;
>> >+ struct list_head dying_entry;
>> > struct cached_fids *cfids;
>> > const char *path;
>> > bool has_lease;
>> >@@ -182,7 +185,8 @@ struct cached_fids {
>> > */
>> > spinlock_t cfid_list_lock;
>> > int num_entries;
>> >- struct list_head entries;
>> >+ struct rb_root entries;
>> >+ struct hlist_head *dentry_ht;
>> > struct list_head dying;
>> > struct delayed_work laundromat_work;
>> > /* aggregate accounting for all cached dirents under this tcon */
>> >diff --git a/fs/smb/client/cifs_debug.c b/fs/smb/client/cifs_debug.c
>> >index 131af7333fc58..9240ee6391dd1 100644
>> >--- a/fs/smb/client/cifs_debug.c
>> >+++ b/fs/smb/client/cifs_debug.c
>> >@@ -328,7 +328,9 @@ static int cifs_debug_dirs_proc_show(struct seq_file *m, void *v)
>> > cfids->num_entries,
>> > (unsigned long)atomic_long_read(&cfids->total_dirents_entries),
>> > (unsigned long long)atomic64_read(&cfids->total_dirents_bytes));
>> >- list_for_each_entry(cfid, &cfids->entries, entry) {
>> >+ for (struct rb_node *rb_node = rb_first(&cfids->entries);
>> >+ rb_node; rb_node = rb_next(rb_node)) {
>> >+ cfid = rb_entry(rb_node, struct cached_fid, node);
>> > spin_lock(&cfid->cfid_lock);
>> > seq_printf(m, "0x%x 0x%llx 0x%llx ",
>> > tcon->tid,
>> >--
>> >2.43.0
>> >
>> >
>
>
>
>--
>Regards,
>Shyam
>
next prev parent reply other threads:[~2026-05-17 19:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 18:08 [PATCH v5 01/17] cifs: invalidate cfid on unlink/rename/rmdir nspmangalore
2026-05-14 18:08 ` [PATCH v5 02/17] cifs: define variable sized buffer for querydir responses nspmangalore
2026-05-14 18:08 ` [PATCH v5 03/17] cifs: optimize readdir for small directories nspmangalore
2026-05-14 18:39 ` Steve French
2026-05-14 18:08 ` [PATCH v5 04/17] cifs: optimize readdir for larger directories nspmangalore
2026-05-14 22:39 ` Steve French
2026-05-14 18:08 ` [PATCH v5 05/17] cifs: reorganize cached dir helpers nspmangalore
2026-05-14 18:08 ` [PATCH v5 06/17] cifs: make cfid locks more granular nspmangalore
2026-05-14 18:08 ` [PATCH v5 07/17] cifs: query dir should reuse cfid even if not fully cached nspmangalore
2026-05-14 18:08 ` [PATCH v5 08/17] cifs: back cached_dirents with page cache nspmangalore
2026-05-14 18:08 ` [PATCH v5 09/17] cifs: in place changes to cached_dirents when dir lease is held nspmangalore
2026-05-14 18:08 ` [PATCH v5 10/17] cifs: register a shrinker to manage cached_dirents nspmangalore
2026-05-14 18:08 ` [PATCH v5 11/17] cifs: option to disable time-based eviction of cache nspmangalore
2026-05-14 18:08 ` [PATCH v5 12/17] cifs: option to set unlimited number of cached dirs nspmangalore
2026-05-14 18:08 ` [PATCH v5 13/17] cifs: allow dcache population to happen asynchronously nspmangalore
2026-05-14 18:08 ` [PATCH v5 14/17] cifs: trace points for cached_dir operations nspmangalore
2026-05-14 18:08 ` [PATCH v5 15/17] cifs: discard functions to ensure that mid callbacks get called nspmangalore
2026-05-14 18:08 ` [PATCH v5 16/17] cifs: keep cfids in rbtree for efficient lookups nspmangalore
2026-05-14 20:43 ` Enzo Matsumiya
2026-05-15 10:49 ` Shyam Prasad N
2026-05-17 19:42 ` Enzo Matsumiya [this message]
2026-05-14 18:08 ` [PATCH v5 17/17] cifs: invalidate cached_dirents if population aborted nspmangalore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agoVi61qbemLWd0i@suse.de \
--to=ematsumiya@suse.de \
--cc=bharathsm@microsoft.com \
--cc=dhowells@redhat.com \
--cc=henrique.carvalho@suse.com \
--cc=linux-cifs@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=pc@manguebit.org \
--cc=smfrench@gmail.com \
--cc=sprasad@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox