From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yunseong Kim <yunseong.kim@est.tech>
Cc: Steve French <stfrench@microsoft.com>,
David Howells <dhowells@redhat.com>,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
linux-kernel@vger.kernel.org, Paulo Alcantara <pc@manguebit.org>,
Namjae Jeon <linkinjeon@kernel.org>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Tom Talpey <tom@talpey.com>, Bharath SM <bharathsm@microsoft.com>
Subject: Re: [PATCH v1 1/1] smb: client: transport: Fix debug printing in __release_mid()
Date: Wed, 26 Aug 2026 11:04:32 +0300 [thread overview]
Message-ID: <ao6eEMYe1l0vFYZE@ashevche-desk.local> (raw)
In-Reply-To: <20260825233419.762040-1-yunseong.kim@est.tech>
On Wed, Aug 26, 2026 at 01:34:06AM +0200, Yunseong Kim wrote:
> On Tue, 25 Aug 2026 10:30:43 +0200 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
...
> > - cifs_info("A: 0x%lx S: 0x%lx R: 0x%lx\n",
> > - now - midEntry->when_alloc,
> > - now - midEntry->when_sent,
> > - now - midEntry->when_received);
> > + pr_debug("slow rsp: cmd %d mid %llu A: 0x%lx S: 0x%lx R: 0x%lx\n",
> > + midEntry->command, midEntry->mid,
>
> The change looks correct to me.
>
> One minor suggestion: could the format string be split using adjacent
> string literals to avoid the long source line?
>
> pr_debug("slow rsp: cmd %d mid %llu "
> "A: 0x%lx S: 0x%lx R: 0x%lx\n",
> ...);
No, the idea is to have long string literals. This was exceptionally done
somewhat 15+ years ago.
See f4c014c0dede ("checkpatch: allow printk strings to exceed 80 characters to
maintain their searchability") as the result of the discussion started here:
https://lore.kernel.org/lkml/20080222132612.GA11717@basil.nowhere.org/
> > + now - midEntry->when_alloc,
> > + now - midEntry->when_sent,
> > + now - midEntry->when_received);
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-08-26 8:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 8:30 [PATCH v1 1/1] smb: client: transport: Fix debug printing in __release_mid() Andy Shevchenko
2026-08-25 23:34 ` Yunseong Kim
2026-08-26 8:04 ` Andy Shevchenko [this message]
2026-08-27 2:22 ` Paulo Alcantara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ao6eEMYe1l0vFYZE@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=bharathsm@microsoft.com \
--cc=dhowells@redhat.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pc@manguebit.org \
--cc=ronniesahlberg@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=sprasad@microsoft.com \
--cc=stfrench@microsoft.com \
--cc=tom@talpey.com \
--cc=yunseong.kim@est.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox