From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-179.mta0.migadu.com (out-179.mta0.migadu.com [91.218.175.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7BC219ADB0 for ; Tue, 3 Mar 2026 02:41:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772505718; cv=none; b=fN9M2aEEnUMgGWNDdCS1EN4wfGlcNwprb7Pmh707Ad58I0doqxRR6sLLY/E7GAdl6x58QjjUVRx3eOAd1NgX4ghSj2yCZonpZVjpsOl0CThN3VXqzQOWhavF4zc1hEmoWEeC/IVIDH9Z50OREkxSIugY72N9wYWwhttt8wiE7JQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772505718; c=relaxed/simple; bh=yfR4WW73Chsypf7R/DSKzbpJukZGpzI3aU99AeL5R3E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N0jjKF199VpBpxJ9vhL5QOFrnsGDopmxSKEG1v0FIBLpzdwymII+Fc64SDp+LmNXAefDhNZIJ0hgk891KM4wCFQKpPA0OfmrAnaen8Nm0BgkPQltVYP7obsZfQDxPdXqiLG1ptAnuCtCNVcpgp2Drhw6WvhxYUYFtA51AzzyY48= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=nDkwIwO1; arc=none smtp.client-ip=91.218.175.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="nDkwIwO1" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1772505715; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2ZStrX35wTKSSx0VLv53Wsqliczl7CjvFkvPYYlZg/o=; b=nDkwIwO1BxfKuRHJ5feROa2o8S7F8YFdwm4I9XcnNo/Wwdwc5TsnjNf8oJ/U/ik2Ihc/M/ sFobxXlUosFpLdgLUlARQbGahjxXcRNNqLQoUP2FU8Erd2moX23vkcGH2u6vT+v7LPmWxb IMqIRukwq6UNZIGyfRxq3fcp2/YYqnM= Date: Tue, 3 Mar 2026 10:41:03 +0800 Precedence: bulk X-Mailing-List: linux-cifs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v4 5/5] smb: introduce struct file_posix_info To: Namjae Jeon Cc: smfrench@gmail.com, chenxiaosong@chenxiaosong.com, linux-cifs@vger.kernel.org, ZhangGuoDong , ChenXiaoSong References: <20260225041100.707468-1-zhang.guodong@linux.dev> <20260225041100.707468-6-zhang.guodong@linux.dev> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: ZhangGuoDong In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Hi Namjae, C structure cannot have two flexible array members. If we make `Sids[]` a flexible array member, then there cannot be any members after it. However, this structure still has `filenamelength` and `filename[]` after it. And `filename[]` is also a flexible array member. Do you have any suggestions for this? 在 2026/2/27 12:37, Namjae Jeon 写道: > You need to add Sids[] flex array here. >> + // var sized owner SID >> + // var sized group SID >> + /* end of POSIX Create Context Response */ >> + // le32 filenamelength >> + // u8 filename[] >> +} __packed;