Re: [PATCH] smb: client: skip cifs_lookup on mkdir

[Henrique Carvalho <henrique.carvalho@suse.com>]

Hi Steve,

On 9/10/25 5:28 PM, Steve French wrote:
> Henrique, I can repro the failure in generic/005 with your patches,
> but am fascinated that one of your patches may have worked around the
> generic/637 problem at least in some cases, but am having difficulty
> bisecting this.

I had not seen the failures in generic/005, but I also had not tested
with smb 2.1.

I will run more tests and dig into both generic/637 and the other
failing cases.

I will get back to you once I have something more concrete.

> 
> On Wed, Sep 10, 2025 at 12:50 PM Steve French <smfrench@gmail.com> wrote:
>>
>> Interesting that running with three of your patches, I no longer see
>> the failure in generic/637 (dir lease related file contents bug) but I
>> do see two unexpected failures in generic/005 and generic/586:
>>
>> http://smb311-linux-testing.southcentralus.cloudapp.azure.com/#/builders/5/builds/116
>>
>> e.g.
>>
>> generic/005 5s ... - output mismatch (see
>> /data/xfstests-dev/results//smb21/generic/005.out.bad)
>>     --- tests/generic/005.out 2024-05-15 02:56:10.033955659 -0500
>>     +++ /data/xfstests-dev/results//smb21/generic/005.out.bad
>> 2025-09-10 08:33:45.271123450 -0500
>>     @@ -1,8 +1,51 @@
>>      QA output created by 005
>>     +ln: failed to create symbolic link 'symlink_00': No such file or directory
>>     +ln: failed to create symbolic link 'symlink_01': No such file or directory
>>     +ln: failed to create symbolic link 'symlink_02': No such file or directory
>>     +ln: failed to create symbolic link 'symlink_03': No such file or directory
>>     +ln: failed to create symbolic link 'symlink_04': No such file or directory
>>     +ln: failed to create symbolic link 'symlink_05': No such file or directory
>>
>> Do you also see these test failures?
>>
>> On Tue, Sep 9, 2025 at 3:30 PM Henrique Carvalho
>> <henrique.carvalho@suse.com> wrote:
>>>
>>> For mkdir the final component is looked up with LOOKUP_CREATE |
>>> LOOKUP_EXCL.
>>>
>>> We don't need an existence check in mkdir; return NULL and let mkdir
>>> create or fail with -EEXIST (on STATUS_OBJECT_NAME_COLLISION).
>>>
>>> Signed-off-by: Henrique Carvalho <henrique.carvalho@suse.com>
>>> ---
>>>  fs/smb/client/dir.c | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/fs/smb/client/dir.c b/fs/smb/client/dir.c
>>> index 5223edf6d11a..d26a14ba6d9b 100644
>>> --- a/fs/smb/client/dir.c
>>> +++ b/fs/smb/client/dir.c
>>> @@ -684,6 +684,10 @@ cifs_lookup(struct inode *parent_dir_inode, struct dentry *direntry,
>>>         void *page;
>>>         int retry_count = 0;
>>>
>>> +       /* if in mkdir, let create path handle it */
>>> +       if (flags == (LOOKUP_CREATE | LOOKUP_EXCL))
>>> +               return NULL;
>>> +
>>>         xid = get_xid();
>>>
>>>         cifs_dbg(FYI, "parent inode = 0x%p name is: %pd and dentry = 0x%p\n",
>>> --
>>> 2.50.1
>>>
>>
>>
>> --
>> Thanks,
>>
>> Steve
> 
> 
> 

-- 
Henrique
SUSE Labs