From: Jeff Layton <jlayton@kernel.org>
To: David Howells <dhowells@redhat.com>, Jeremy Allison <jra@samba.org>
Cc: Steve French <smfrench@gmail.com>,
Namjae Jeon <linkinjeon@kernel.org>,
ronniesahlberg@gmail.com, Tom Talpey <tom@talpey.com>,
Stefan Metzmacher <metze@samba.org>,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org
Subject: Re: Can fallocate() ops be emulated better using SMB request compounding?
Date: Thu, 07 Dec 2023 13:18:10 -0500 [thread overview]
Message-ID: <be2cce395511f42412d698cf35f11363d47ad580.camel@kernel.org> (raw)
In-Reply-To: <1215461.1701971450@warthog.procyon.org.uk>
On Thu, 2023-12-07 at 17:50 +0000, David Howells wrote:
> Jeremy Allison <jra@samba.org> wrote:
>
> > > Further, are the two ops then essentially done atomically?
> >
> > No. They are processed (at least in Samba) as two separate
> > requests and can be raced by local or other remote access.
>
> So just compounding them would leave us in the same situation we are in now -
> which would be fine.
>
> What do you think about the idea of having the server see a specifically
> arranged compounded pair and turn them into an op that can't otherwise be
> represented in the protocol?
>
> Or is it better to try and get the protocol extended?
>
I think you have to extend the protocol. You might be able to fix one
server to treat the two operations atomically, but there are tons of SMB
servers in the field. The client can't really depend that that will
always do the right thing.
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2023-12-07 18:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 15:58 Can fallocate() ops be emulated better using SMB request compounding? David Howells
2023-12-07 17:40 ` Jeremy Allison
2023-12-07 17:50 ` David Howells
2023-12-07 18:18 ` Jeff Layton [this message]
2023-12-07 18:32 ` Jeremy Allison
2023-12-07 20:25 ` Tom Talpey
2023-12-08 14:03 ` Steve French
2023-12-07 18:12 ` Paulo Alcantara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be2cce395511f42412d698cf35f11363d47ad580.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=dhowells@redhat.com \
--cc=jra@samba.org \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=metze@samba.org \
--cc=ronniesahlberg@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=smfrench@gmail.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox