public inbox for linux-cifs@vger.kernel.org
 help / color / mirror / Atom feed
From: samba-bugs@samba.org
To: cifs-qa@samba.org
Subject: [Bug 13712] Unable to access files below folder name with trailing dot or space
Date: Thu, 07 Jan 2021 15:34:42 +0000	[thread overview]
Message-ID: <bug-13712-10630-wUPXz6CZjW@https.bugzilla.samba.org/> (raw)
In-Reply-To: <bug-13712-10630@https.bugzilla.samba.org/>

https://bugzilla.samba.org/show_bug.cgi?id=13712

--- Comment #4 from Steve French <sfrench@samba.org> ---
Can you tell me which version you still see it failing in?  It works for me in
5.10. See below:

root@smfrench-ThinkPad-P52:/mnt2# mkdir subdir
root@smfrench-ThinkPad-P52:/mnt2# cd subdir
root@smfrench-ThinkPad-P52:/mnt2/subdir# mkdir dir-trailing-dot.
root@smfrench-ThinkPad-P52:/mnt2/subdir# ls
dir-trailing-dot.
root@smfrench-ThinkPad-P52:/mnt2/subdir# echo foo > dir-trailing-dot./foo
root@smfrench-ThinkPad-P52:/mnt2/subdir# mkdir x
root@smfrench-ThinkPad-P52:/mnt2/subdir# echo foo > x/foo
root@smfrench-ThinkPad-P52:/mnt2/subdir# mv x dir2-trailing-dot.
root@smfrench-ThinkPad-P52:/mnt2/subdir# ls dir2-trailing-dot.
foo
root@smfrench-ThinkPad-P52:/mnt2/subdir# cat dir2-trailing-dot./foo
foo
root@smfrench-ThinkPad-P52:/mnt2/subdir# mount | grep cifs
//localhost/scratch on /mnt2 type cifs
(rw,relatime,vers=3.1.1,cache=strict,username=smfrench,uid=0,noforceuid,gid=0,noforcegid,addr=127.0.0.1,file_mode=0755,dir_mode=0755,soft,nounix,serverino,mapposix,mfsymlinks,rsize=4194304,wsize=4194304,bsize=1048576,echo_interval=60,actimeo=1)

This was fixed multiple years ago in patch:
commit 45e8a2583d97ca758a55c608f78c4cef562644d1
Author: Steve French <smfrench@gmail.com>
Date:   Wed Jun 22 21:07:32 2016 -0500

    File names with trailing period or space need special case conversion

    POSIX allows files with trailing spaces or a trailing period but
    SMB3 does not, so convert these using the normal Services For Mac
    mapping as we do for other reserved characters such as
            : < > | ? *
    This is similar to what Macs do for the same problem over SMB3.

    CC: Stable <stable@vger.kernel.org>
    Signed-off-by: Steve French <steve.french@primarydata.com>
    Acked-by: Pavel Shilovsky <pshilovsky@samba.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

  parent reply	other threads:[~2021-01-07 15:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-13712-10630@https.bugzilla.samba.org/>
2021-01-07 14:46 ` [Bug 13712] Unable to access files below folder name with trailing dot or space samba-bugs
2021-01-07 14:57 ` samba-bugs
2021-01-07 15:34 ` samba-bugs [this message]
2021-01-07 15:46 ` samba-bugs
2021-01-07 16:03 ` samba-bugs
2021-01-08  0:02 ` samba-bugs
2021-01-08  0:03 ` samba-bugs
2021-01-09 23:40 ` samba-bugs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-13712-10630-wUPXz6CZjW@https.bugzilla.samba.org/ \
    --to=samba-bugs@samba.org \
    --cc=cifs-qa@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox