From: Frank Sorenson <sorenson@redhat.com>
To: Namjae Jeon <linkinjeon@kernel.org>
Cc: linux-cifs@vger.kernel.org, pc@manguebit.org, stable@vger.kernel.org
Subject: Re: [PATCH] smb: client: fix potential use-after-free with TCP_Server_Info->hostname
Date: Thu, 17 Sep 2026 20:52:02 -0500 [thread overview]
Message-ID: <c2dd4bc7-413e-4ebb-b94e-2c61e3fcee17@redhat.com> (raw)
In-Reply-To: <CAKYAXd9UW34G21Xr6kUArCGsKUQZxz7ttkuCcdE9tVgyXNWTNA@mail.gmail.com>
On 9/17/26 8:47 PM, Namjae Jeon wrote:
>> diff --git a/fs/smb/client/smb2pdu.c b/fs/smb/client/smb2pdu.c
>> index dea05aeb53a1..bb30cfa156aa 100644
>> --- a/fs/smb/client/smb2pdu.c
>> +++ b/fs/smb/client/smb2pdu.c
>> @@ -173,9 +173,8 @@ cifs_chan_skip_or_disable(struct cifs_ses *ses,
>> unsigned int chan_index;
>>
>> if (SERVER_IS_CHAN(server)) {
>> - cifs_dbg(VFS,
>> - "server %s does not support multichannel anymore. Skip secondary channel\n",
>> - ses->server->hostname);
>> + cifs_server_dbg(VFS,
>> + "server does not support multichannel anymore. Skip secondary channel\n");
> Since SERVER_IS_CHAN(server) means that server is a secondary channel,
> Is it intentional that this now logs the secondary hostname instead of
> the primary hostname?
No, not intentional... I missed that server != ses->server at this
point, so the patch is wrong.
Frank
--
Frank Sorenson
sorenson@redhat.com
Principal Software Maintenance Engineer, filesystems
Red Hat
prev parent reply other threads:[~2026-09-18 1:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 0:33 [PATCH] smb: client: fix potential use-after-free with TCP_Server_Info->hostname Frank Sorenson
2026-09-18 1:44 ` Frank Sorenson
2026-09-18 1:47 ` Namjae Jeon
2026-09-18 1:52 ` Frank Sorenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2dd4bc7-413e-4ebb-b94e-2c61e3fcee17@redhat.com \
--to=sorenson@redhat.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=pc@manguebit.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox