From: Paulo Alcantara <pc@manguebit.org>
To: sorenson@redhat.com, CIFS <linux-cifs@vger.kernel.org>
Cc: Namjae Jeon <linkinjeon@kernel.org>,
Henrique Carvalho <henrique.carvalho@suse.com>
Subject: Re: [Discuss] smb: client: bitfield aliasing and locking chaos in cifsFileInfo
Date: Wed, 30 Sep 2026 14:56:27 -0300 [thread overview]
Message-ID: <c49a534edb402ce127e794a948681ef6@manguebit.org> (raw)
In-Reply-To: <7689764e-c0f6-4016-9557-b54cf4a3de4e@redhat.com>
Frank Sorenson <sorenson@redhat.com> writes:
> I ran xfstests on cifs/cifs-next (7.3-rc3+) with KCSAN enabled, and caught
> a number of data races in the smb client.
>
> The most concerning finding is a structural bitfield aliasing issue in
> 'struct cifsFileInfo'.
Nice catch.
Please take a look at the following fix from Henrique
ec306600d5ba ("smb: client: split cached_fid bitfields to avoid shared-byte RMW races")
You should probably fix them the same way.
Regarding the serialisation on them, yes, we would to check which one
really requires it. That could be done separately, too.
prev parent reply other threads:[~2026-09-30 17:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-26 21:16 [Discuss] smb: client: bitfield aliasing and locking chaos in cifsFileInfo Frank Sorenson
2026-09-30 17:56 ` Paulo Alcantara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c49a534edb402ce127e794a948681ef6@manguebit.org \
--to=pc@manguebit.org \
--cc=henrique.carvalho@suse.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=sorenson@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox