Linux CIFS filesystem development
 help / color / mirror / Atom feed
From: Andrew Bartlett <abartlet@samba.org>
To: Steve French <smfrench@gmail.com>
Cc: Kevin Ottens <kevin.ottens@enioka.com>, linux-cifs@vger.kernel.org
Subject: Re: Different behavior of POSIX file locks depending on cache mode
Date: Tue, 11 Jun 2024 08:50:11 +1200	[thread overview]
Message-ID: <cc83f0cbd1409492bdfa17fd2c2f6afb5fa5ee8c.camel@samba.org> (raw)
In-Reply-To: <CAH2r5mu_5V1OXwiOa2csH9n_J+ZPDYNhiuYBDoONYBqewNaNkQ@mail.gmail.com>

(again, resend without HTML)

On Mon, 2024-06-10 at 15:05 -0500, Steve French wrote:
> Yes - the reproducer helps.  The bug is easy to reproduce.
> 
> I wanted to verify that the succeeding cases are the same that I see:
> - works with "cache=none"
> and
> - works with "nobrl"
> and
> - works with "vers=1.0"
> 
> All other combinations fail ...
> 
> Should be straightforward to fix in cifs.ko.  Will look at a fix for
> this later today.

Awesome, thanks. 

> Note that the problem with SMB3.1.1 POSIX extensions is a Samba bug -
> a serious regression in the server (but trivial fix).  We are waiting
> on someone to merge the oneline fix to the server (which we tested
> out
> ok) from David.

Is there an MR for this?  I couldn't find it.

Andrew Bartlett

-- 

Andrew Bartlett (he/him)       https://samba.org/~abartlet/
Samba Team Member (since 2001) https://samba.org
Samba Team Lead                https://catalyst.net.nz/services/samba
Catalyst.Net Ltd

Proudly developing Samba for Catalyst.Net Ltd - a Catalyst IT group
company

Samba Development and Support: https://catalyst.net.nz/services/samba

Catalyst IT - Expert Open Source Solutions

-- 
Andrew Bartlett (he/him)       https://samba.org/~abartlet/
Samba Team Member (since 2001) https://samba.org
Samba Team Lead                https://catalyst.net.nz/services/samba
Catalyst.Net Ltd

Proudly developing Samba for Catalyst.Net Ltd - a Catalyst IT group
company

Samba Development and Support: https://catalyst.net.nz/services/samba

Catalyst IT - Expert Open Source Solutions


  reply	other threads:[~2024-06-10 20:50 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-23 16:08 Different behavior of POSIX file locks depending on cache mode Kevin Ottens
2024-05-23 16:12 ` Steve French
2024-05-27 16:38   ` Kevin Ottens
2024-06-10  4:41   ` Andrew Bartlett
2024-06-10 20:05     ` Steve French
2024-06-10 20:50       ` Andrew Bartlett [this message]
     [not found]       ` <c6da3de7c205d40a41907874a0e6d26b6c8132fe.camel@samba.org>
2024-06-10 20:53         ` Steve French
2024-06-10 20:57           ` Andrew Bartlett
2024-06-10 21:19           ` Ralph Boehme
2024-06-10 22:49             ` Steve French
2024-06-10 22:53               ` Steve French
2024-06-24  4:54     ` Steve French
2024-06-25  6:00       ` Andrew Bartlett
2024-06-25  7:41         ` Kevin Ottens
2024-06-27 15:04           ` Kevin Ottens
2024-07-10  9:28             ` Andrew Bartlett
2024-07-11  2:03               ` Steve French
2024-07-11  4:20                 ` Andrew Bartlett
2024-08-15 20:47     ` Steve French
2024-08-22 17:06       ` Kevin Ottens
2024-09-01  4:48         ` Steve French

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc83f0cbd1409492bdfa17fd2c2f6afb5fa5ee8c.camel@samba.org \
    --to=abartlet@samba.org \
    --cc=kevin.ottens@enioka.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox