From: ChenXiaoSong <chenxiaosong.chenxiaosong@linux.dev>
To: sfrench@samba.org, smfrench@gmail.com, linkinjeon@kernel.org,
linkinjeon@samba.org
Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org,
liuzhengyuan@kylinos.cn, huhai@kylinos.cn, liuyun01@kylinos.cn
Subject: Re: [PATCH v4 00/10] smb: improve search speed of SMB2 maperror
Date: Wed, 10 Dec 2025 12:29:20 +0800 [thread overview]
Message-ID: <ce09c209-c97e-4dcb-b3a7-b18ba56a86a1@linux.dev> (raw)
In-Reply-To: <20251206151826.2932970-1-chenxiaosong.chenxiaosong@linux.dev>
Hi Steve and Namjae,
I have tested all patches using KUnit tests, xfstests, and smbtorture,
and no additional test failures were observed. The detailed test results
can be found in: https://chenxiaosong.com/en/smb-test-20251210.html
For more detailed information about the patches to be reviewed, please
see the link: https://chenxiaosong.com/en/smb-patch.html
Thanks,
ChenXiaoSong.
On 12/6/25 23:18, chenxiaosong.chenxiaosong@linux.dev wrote:
> From: ChenXiaoSong <chenxiaosong@kylinos.cn>
>
> Before applying this patchset, when searching for the last element of
> smb2_error_map_table array and calling smb2_print_status(),
> 3486 comparisons are needed.
>
> After applying this patchset, only 10 comparisons are required.
>
> v1: https://lore.kernel.org/linux-cifs/20251204045818.2590727-1-chenxiaosong.chenxiaosong@linux.dev/
> The three patches from v1 have already been applied to the for-next branch of cifs-2.6.git.
> Please replace the following patches:
>
> - [v1 01/10] smb/client: reduce loop count in map_smb2_to_linux_error() by half: https://git.samba.org/sfrench/?p=sfrench/cifs-2.6.git;a=commitdiff;h=26866d690bd180e1860548c43e70fdefe50638ff
> - Replace it with this version(v4) patch #0001: update commit message: array has 1743 elements
>
> - [v1 02/10] smb/client: remove unused elements from smb2_error_map_table array: https://git.samba.org/sfrench/?p=sfrench/cifs-2.6.git;a=commitdiff;h=905d8999d67dcbe4ce12ef87996e4440e068196d
> - It is the same as patch #0002 in this version(v4).
>
> - [v1 03/10] smb: add two elements to smb2_error_map_table array: https://git.samba.org/sfrench/?p=sfrench/cifs-2.6.git;a=commitdiff;h=ba521f56912f6ff5121e54c17c855298f947c9ea
> - Replace it with this version(v4) patch #0003 #0004.
>
> v3: https://lore.kernel.org/linux-cifs/20251205132536.2703110-1-chenxiaosong.chenxiaosong@linux.dev/
> v3->v4:
> - Patch #0008: the KUnit test searches all elements of the smb2_error_map_table array
> - Create patch #0009
>
> ChenXiaoSong (10):
> smb/client: reduce loop count in map_smb2_to_linux_error() by half
> smb/client: remove unused elements from smb2_error_map_table array
> smb: rename to STATUS_SMB_NO_PREAUTH_INTEGRITY_HASH_OVERLAP
> smb/client: add two elements to smb2_error_map_table array
> smb/client: sort smb2_error_map_table array
> smb/client: use bsearch() to find target status code
> smb/client: introduce smb2_get_err_map()
> smb/client: introduce smb2maperror KUnit tests
> smb/client: update some SMB2 status strings
> smb/server: rename include guard in smb_common.h
>
> fs/smb/Kconfig | 17 +++++
> fs/smb/client/cifsfs.c | 2 +
> fs/smb/client/smb2glob.h | 6 ++
> fs/smb/client/smb2maperror.c | 101 +++++++++++++++++-------------
> fs/smb/client/smb2maperror_test.c | 71 +++++++++++++++++++++
> fs/smb/client/smb2proto.h | 4 +-
> fs/smb/common/smb2status.h | 5 +-
> fs/smb/server/smb2pdu.c | 2 +-
> fs/smb/server/smb_common.h | 6 +-
> 9 files changed, 165 insertions(+), 49 deletions(-)
> create mode 100644 fs/smb/client/smb2maperror_test.c
>
prev parent reply other threads:[~2025-12-10 4:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-06 15:18 [PATCH v4 00/10] smb: improve search speed of SMB2 maperror chenxiaosong.chenxiaosong
2025-12-06 15:18 ` [PATCH v4 01/10] smb/client: reduce loop count in map_smb2_to_linux_error() by half chenxiaosong.chenxiaosong
2025-12-06 15:18 ` [PATCH v4 02/10] smb/client: remove unused elements from smb2_error_map_table array chenxiaosong.chenxiaosong
2025-12-06 15:18 ` [PATCH v4 03/10] smb: rename to STATUS_SMB_NO_PREAUTH_INTEGRITY_HASH_OVERLAP chenxiaosong.chenxiaosong
2025-12-06 15:18 ` [PATCH v4 04/10] smb/client: add two elements to smb2_error_map_table array chenxiaosong.chenxiaosong
2025-12-06 15:18 ` [PATCH v4 05/10] smb/client: sort " chenxiaosong.chenxiaosong
2025-12-06 15:18 ` [PATCH v4 06/10] smb/client: use bsearch() to find target status code chenxiaosong.chenxiaosong
2025-12-06 15:18 ` [PATCH v4 07/10] smb/client: introduce smb2_get_err_map() chenxiaosong.chenxiaosong
2025-12-06 15:18 ` [PATCH v4 08/10] smb/client: introduce smb2maperror KUnit tests chenxiaosong.chenxiaosong
2025-12-08 21:29 ` kernel test robot
2025-12-09 3:45 ` kernel test robot
2025-12-06 15:18 ` [PATCH v4 09/10] smb/client: update some SMB2 status strings chenxiaosong.chenxiaosong
2025-12-07 17:47 ` Steve French
2025-12-06 15:18 ` [PATCH v4 10/10] smb/server: rename include guard in smb_common.h chenxiaosong.chenxiaosong
2025-12-10 4:29 ` ChenXiaoSong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce09c209-c97e-4dcb-b3a7-b18ba56a86a1@linux.dev \
--to=chenxiaosong.chenxiaosong@linux.dev \
--cc=huhai@kylinos.cn \
--cc=linkinjeon@kernel.org \
--cc=linkinjeon@samba.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyun01@kylinos.cn \
--cc=liuzhengyuan@kylinos.cn \
--cc=sfrench@samba.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).