linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Metzmacher <metze@samba.org>
To: linux-cifs@vger.kernel.org, samba-technical@lists.samba.org
Cc: metze@samba.org
Subject: [PATCH 0/5] smb: smbdirect: introduce local send credits
Date: Mon, 20 Oct 2025 20:35:57 +0200	[thread overview]
Message-ID: <cover.1760984605.git.metze@samba.org> (raw)

Hi,

our client already has some logic to prevent overflows of
the local submission queue for ib_post_send(), if the peer
granted more credits than we asked for.

But it's not as easy as it could be.

I guess that won't happen against Windows, but our git
history indicates this could happen.

Now we have a loop of local credits based on our send_credit_target.
With that we always try to get a local credit first and then
get a remote credit. When we got both we are able to
mark the request as pending in order to keep the
existing logic based on the pending count working.
Removing or changing that is a task for another day,
when all code if in common between client and server.

For the server this is a real bug fix, as such a logic was missing
before.

For the client it's not strictly required for 6.18, but
I think we should keep things consistent, as it will reduce
churn on my 6.19 patchset, which already has about 100 patches
and brings things into common code. And more is comming there...

Stefan Metzmacher (5):
  smb: smbdirect: introduce smbdirect_socket.send_io.lcredits.*
  smb: server: smb_direct_disconnect_rdma_connection() already wakes all
    waiters on error
  smb: server: simplify sibling_list handling in
    smb_direct_flush_send_list/send_done
  smb: server: make use of smbdirect_socket.send_io.lcredits.*
  smb: client: make use of smbdirect_socket.send_io.lcredits.*

 fs/smb/client/smbdirect.c                  |  67 ++++++++-----
 fs/smb/common/smbdirect/smbdirect_socket.h |  13 ++-
 fs/smb/server/transport_rdma.c             | 106 +++++++++++++++------
 3 files changed, 129 insertions(+), 57 deletions(-)

-- 
2.43.0


             reply	other threads:[~2025-10-20 18:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-20 18:35 Stefan Metzmacher [this message]
2025-10-20 18:35 ` [PATCH 1/5] smb: smbdirect: introduce smbdirect_socket.send_io.lcredits.* Stefan Metzmacher
2025-10-20 18:35 ` [PATCH 2/5] smb: server: smb_direct_disconnect_rdma_connection() already wakes all waiters on error Stefan Metzmacher
2025-10-20 18:36 ` [PATCH 3/5] smb: server: simplify sibling_list handling in smb_direct_flush_send_list/send_done Stefan Metzmacher
2025-10-20 18:36 ` [PATCH 4/5] smb: server: make use of smbdirect_socket.send_io.lcredits.* Stefan Metzmacher
2025-10-20 18:36 ` [PATCH 5/5] smb: client: " Stefan Metzmacher
2025-10-21  6:51 ` [PATCH 0/5] smb: smbdirect: introduce local send credits Namjae Jeon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1760984605.git.metze@samba.org \
    --to=metze@samba.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=samba-technical@lists.samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).