public inbox for linux-cifs@vger.kernel.org
 help / color / mirror / Atom feed
From: Stefan Metzmacher <metze@samba.org>
To: linux-cifs@vger.kernel.org, samba-technical@lists.samba.org
Cc: metze@samba.org, Namjae Jeon <linkinjeon@kernel.org>,
	Steve French <smfrench@gmail.com>, Tom Talpey <tom@talpey.com>,
	Ruikai Peng <ruikai@pwno.io>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	Paulo Alcantara <pc@manguebit.org>,
	security@kernel.org
Subject: [PATCH 0/2] SMB Direct: double-free of send_io on ib_post_send failure in batch flush path
Date: Fri, 10 Apr 2026 22:10:59 +0200	[thread overview]
Message-ID: <cover.1775838249.git.metze@samba.org> (raw)

Hi Steve,

here are the real patches for the changes already tested by
Ruikai Peng for the double-free problem reported, see:
https://lore.kernel.org/linux-cifs/CAFD3drNOSJ05y3A+jNXSDxW-2w09KHQ0DivhxQ_pcc7immVVOQ@mail.gmail.com/

I prepared a branch that can replace ksmbd-for-next.
The 2 changes are rebased below the smbdirect.ko changes,
I resolved the conflicts and made sure the problem is also solved in
the new common code. This in for-7.1/smbdirect-ko-20260410-v12
at commit: 274b415378bbd0cf6fde1a719e264cee2eefc06f
git fetch https://git.samba.org/metze/linux/wip.git for-7.1/smbdirect-ko-20260410-v12
https://git.samba.org/?p=metze/linux/wip.git;a=shortlog;h=refs/heads/for-7.1/smbdirect-ko-20260410-v12
I made sure each commit compiles fine...


Stefan Metzmacher (2):
  smb: client: avoid double-free in smbd_free_send_io() after
    smbd_send_batch_flush()
  smb: server: avoid double-free in smb_direct_free_sendmsg after
    smb_direct_flush_send_list()

 fs/smb/client/smbdirect.c      | 8 ++++++++
 fs/smb/server/transport_rdma.c | 8 +++++++-
 2 files changed, 15 insertions(+), 1 deletion(-)

-- 
2.43.0


             reply	other threads:[~2026-04-10 20:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-10 20:10 Stefan Metzmacher [this message]
2026-04-10 20:11 ` [PATCH 1/2] smb: client: avoid double-free in smbd_free_send_io() after smbd_send_batch_flush() Stefan Metzmacher
2026-04-10 20:11 ` [PATCH 2/2] smb: server: avoid double-free in smb_direct_free_sendmsg after smb_direct_flush_send_list() Stefan Metzmacher
2026-04-10 20:30 ` [PATCH 0/2] SMB Direct: double-free of send_io on ib_post_send failure in batch flush path Paulo Alcantara
2026-04-11  0:51 ` Namjae Jeon
2026-04-11  1:31   ` Steve French

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1775838249.git.metze@samba.org \
    --to=metze@samba.org \
    --cc=linkinjeon@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=pc@manguebit.org \
    --cc=ruikai@pwno.io \
    --cc=samba-technical@lists.samba.org \
    --cc=security@kernel.org \
    --cc=senozhatsky@chromium.org \
    --cc=smfrench@gmail.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox